Skip to content

Conversation

stephancill
Copy link
Contributor

@stephancill stephancill commented Apr 25, 2025

Summary

  • fix: account ordering for wallet_addSubAccount
  • feat: signer selector on /auto-sub-account page
  • fix: convert errors thrown by viem to make them more readable
  • fix: handle errors from other versions of viem

How did you test your changes?

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@stephancill stephancill changed the base branch from master to feat/paymaster-config April 25, 2025 15:02
Base automatically changed from feat/paymaster-config to feat/jit-spend-permissions April 25, 2025 15:12
@stephancill stephancill marked this pull request as ready for review April 25, 2025 19:23
@cb-jake cb-jake merged commit 68db706 into feat/jit-spend-permissions Apr 25, 2025
5 checks passed
@cb-jake cb-jake deleted the fix/canary-patches branch April 25, 2025 19:30
stephancill added a commit that referenced this pull request Apr 25, 2025
* feat: jit spend permissions

* feat: snackbar

* fix: construction of original calls

* fix: existing tests

* chore: refactor error handling logic

* chore: tests for handleInsufficientBalanceError

* feat: batch spend permissions message

* fix: sub accounts config shape

* fix: typecheck

* feat: paymaster urls in config (#1612)

* feat: paymaster urls in config

* fix: capabilties arg in createWalletSendCallsRequest

* fix: createWalletSendCallsRequest chainId type

* fix: canary patches (#1614)

* fix: account ordering for wallet_addSubAccount

* feat: signer selector on /auto-sub-account page

* fix: convert errors thrown by viem

* fix: handle errors from other versions of viem

* fix: create new spend limit toast option title

* feat: sub accounts data suffix support (#1613)

* feat: sub accounts data suffix support

* fix: capabilities type

* fix: tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants