feat: sub accounts data suffix support #1613
Merged
+202
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
fan-zhang-sv
previously approved these changes
Apr 25, 2025
stephancill
force-pushed
the
feat/sub-account-data-suffix
branch
from
e5bf02b to
f415f61
Compare
cb-heimdall
dismissed stale reviews from cb-jake and fan-zhang-sv
Approved review 2794449227 from cb-jake is now dismissed due to new commit. Re-request for approval.
fan-zhang-sv
approved these changes
Apr 25, 2025
stephancill
added a commit
that referenced
this pull request
Apr 25, 2025
* feat: jit spend permissions * feat: snackbar * fix: construction of original calls * fix: existing tests * chore: refactor error handling logic * chore: tests for handleInsufficientBalanceError * feat: batch spend permissions message * fix: sub accounts config shape * fix: typecheck * feat: paymaster urls in config (#1612) * feat: paymaster urls in config * fix: capabilties arg in createWalletSendCallsRequest * fix: createWalletSendCallsRequest chainId type * fix: canary patches (#1614) * fix: account ordering for wallet_addSubAccount * feat: signer selector on /auto-sub-account page * fix: convert errors thrown by viem * fix: handle errors from other versions of viem * fix: create new spend limit toast option title * feat: sub accounts data suffix support (#1613) * feat: sub accounts data suffix support * fix: capabilities type * fix: tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
wallet_prepareCallsto createSubAccountSignerHow did you test your changes?