Skip to content

Release v0.4.0 #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 7, 2024
Merged

Release v0.4.0 #225

merged 9 commits into from
Sep 7, 2024

Conversation

@rohan-agarwal-coinbase
Copy link
Contributor

@rohan-agarwal-coinbase rohan-agarwal-coinbase commented Sep 6, 2024

What changed? Why?

  • Update getDefaultAddress and getAddress to fetch addresses if not loaded. The change to the interfaces are backward-incompatible, which is why we bumped the minor version

rohan-agarwal-coinbase and others added 9 commits September 6, 2024 12:46
@rohan-agarwal-coinbase
Remove yarn.lock file since we use npm to build (#218)
a4d67dc
@howard-at-cb
Update api.ts
2ae8989
@howard-at-cb
fix tests
d775021
@howard-at-cb
Update types.ts
ea91d1f
@howard-at-cb
Update api.ts
9969cd7
@howard-at-cb
Update address_test.ts
3d0c6c2
@howard-at-cb
Merge pull request #223 from coinbase/hx-add-data-scope
7cbd7ed 
support new scope in CDP change
@rohan-agarwal-coinbase
Update getDefaultAddress and getAddress to fetch addresses if not loa…
98687bf 
…ded (#217)

* Update getDefaultAddress and getAddress to fetch addresses if not loaded

* Address feedback

* lint

* WIP

* Fix e2e test

* Fix

* 1 failing test

* Cleanup

* Fix

* more test coverage

* Address feedback

* Improve

* Update jest config
@rohan-agarwal-coinbase
Bump package to 0.4.0 to prepare for release (#224)
98f133a
@cb-heimdall
Copy link

cb-heimdall commented Sep 6, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@rohan-agarwal-coinbase rohan-agarwal-coinbase merged commit 2e5ff3e into master Sep 7, 2024
@jazz-cb jazz-cb deleted the v0.4.0 branch September 7, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jazz-cb jazz-cb jazz-cb approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rohan-agarwal-coinbase @cb-heimdall @jazz-cb @howard-at-cb