-
Notifications
You must be signed in to change notification settings - Fork 85
Update getDefaultAddress and getAddress to fetch addresses if not loaded #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
68d7bdd to
367b662
Compare
Contributor
|
Since this is a breaking change, we will need to update README.md examples, the quickstarts in |
Contributor
Author
thanks @John-peterson-coinbase i updated the PR:
Will update the CDP docs next |
John-peterson-coinbase
approved these changes
Sep 6, 2024
rohan-agarwal-coinbase
added a commit
that referenced
this pull request
Sep 7, 2024
* Remove yarn.lock file since we use npm to build (#218) * Update getDefaultAddress and getAddress to fetch addresses if not loaded (#217) * Bump package to 0.4.0 to prepare for release (#224) --------- Co-authored-by: Howard Xie <howard.xie@coinbase.com> Co-authored-by: cb-howardatcb <86798563+howard-at-cb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Updates
getDefaultAddressandgetAddressto fetchaddressesif it is not loaded/cached, which occurs right when creating a new wallet.This PR tightens the interfaces for both functions.
getDefaultAddressno longer returns undefined and throws an error.getAddressnow returns aPromise<WalletAddress>instead ofAddresssince it callslistAddresses. This is backward-incompatibleTesting
Updated unit tests. I also wrote and ran a test script locally that succeeds to get the default address after fetching a wallet, which was earlier failing.
Qualified Impact
Getting addresses has changed with new side effects, and the interfaces have changed in an backward-incompatible way so fixing issues would require client-side changes.