V0.1.0 SDK Release #176
Merged
V0.1.0 SDK Release #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [HistoricalBalances] add wallet level function * fix format * refine comment
Expose toAddressId() method on Transaction class
This makes it so that the SDK passes the address index when deriving and registering addreses. This is important so that we can properly track the address index on the backend and ensure we return addresses in the appopriate order.
comments test and make constructor private add types for params npm run format
Pass address index when registering address
Cleanup staking operation + wallet address related code
This makes it so that we dynamically update networks as we update our OpenAPI spec. This does not add a whole network object like we have in ruby, because we probably want to play around with how people want to use the various objects in TS before doing that.
This should be moved to the backend similar to the ruby SDK, however that will require a bit of a refactor around the network objects.
…constants Support dynamic network constants
This removes the user concept in favor of directly creating, listing, importing, and fetching wallets.
This updates the docs, readmes, and changelog to reflect the removal of the user concept.
This adds a correlation context header that includes the version and language of the SDK. This will be used to track what versions of the SDK developers are using and to help reach out to upgrade versions.
Add correlation context to request headers
…t_model Add wallet model support for Dedicated ETH Staking
* [hotfix] patch for page setting * add test case
Remove user concept
✅ Heimdall Review Status
|
jazz-cb
previously approved these changes
Aug 22, 2024
This decouples the action of creating a transfer or trade object from the actual waiting for it to confirm or fail on-chain. Without this we cannot create many transfer concurrently without running into a plethora of 429 issues. We also cannot recover gracefully since we never get the transfer object returns, so cannot subsequently make fetches for its status if it happens to fail (or returns a temporary error, e.g. 429).
cb-heimdall
dismissed
jazz-cb’s stale review
Approved review 2255535173 from jazz-cb is now dismissed due to new commit. Re-request for approval.
jazz-cb
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This preps the
v0.1.0version for release[0.1.0] - 2024-08-22
Added
listHistoricalBalanceswallet method, that lists the historical balances for the wallet's default address.Removed
isTerminalState,isFailedStateandisCompleteState.Changed
createTransferandcreateTradefunctions no longer wait for the transactions to confirm orfail on-chain.
TransferandTradeobject respectively, which support thewaitfunction, e.g.
await transfer.wait().waiting to land on-chain.
reload()method to work with both External and Wallet address.createStakingOperationlogic to make sure we only pull in newer unsigned txs from the server.This is especially important for External Address use-case where tx signing and broadcast status is maintained on client side, and we risk overwriting the existing txs.
createStakingOperationto 10 min.Qualified Impact