Skip to content

Conversation

@xinyu-li-cb
Copy link
Contributor

@xinyu-li-cb xinyu-li-cb commented Aug 14, 2024

What changed? Why?

Add wallet level function for get historical balances: fetch historical balances for default address.

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Aug 14, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

1 similar comment
@cb-heimdall
Copy link

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@xinyu-li-cb xinyu-li-cb changed the base branch from master to v0.1.0 August 14, 2024 22:48
@xinyu-li-cb xinyu-li-cb marked this pull request as ready for review August 14, 2024 22:48
@xinyu-li-cb xinyu-li-cb merged commit 5f03ebb into v0.1.0 Aug 15, 2024
shreifabdallah pushed a commit that referenced this pull request Aug 20, 2024
* [HistoricalBalances] add wallet level function

* fix format

* refine comment
shreifabdallah pushed a commit that referenced this pull request Aug 21, 2024
* [HistoricalBalances] add wallet level function

* fix format

* refine comment
@xinyu-li-cb xinyu-li-cb deleted the wallethistory branch August 22, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants