Skip to content

(feat): adds e2e test with registration and login workflow#97

Merged
sjaghori merged 4 commits intomainfrom
feat_e2e-registration+login-flow
Jun 17, 2024
Merged

(feat): adds e2e test with registration and login workflow#97
sjaghori merged 4 commits intomainfrom
feat_e2e-registration+login-flow

Conversation

@sjaghori
Copy link
Collaborator

No description provided.

@sjaghori sjaghori requested a review from mledl as a code owner June 16, 2024 17:01
@sjaghori sjaghori force-pushed the feat_e2e-registration+login-flow branch from 108512b to 89288bd Compare June 16, 2024 17:04
@sjaghori
Copy link
Collaborator Author

#10

Copy link
Member

@benjaminstrasser benjaminstrasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!
just some small stuff.
The test is currently failing if you run it multiple times. See #10

Create a test/reset endpoint to reset the database, secured with an environment variable and a JWT.

What are thoughts on this approach?

@sjaghori sjaghori force-pushed the feat_e2e-registration+login-flow branch from 89288bd to c5e9be7 Compare June 16, 2024 20:07
@sjaghori
Copy link
Collaborator Author

nice work! just some small stuff. The test is currently failing if you run it multiple times. See #10

Create a test/reset endpoint to reset the database, secured with an environment variable and a JWT.

What are thoughts on this approach?

Agree we need a strategy for that, for now this setup is sufficient for the single test that we have. It's out of scope for this PR, there are some good ways (session storage, multiple workers etc.) that we can discuss.

Just by adding this simple registration/login flow test, we already protected ourself from non-obvious failing releases.

Copy link
Member

@benjaminstrasser benjaminstrasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benjaminstrasser
Copy link
Member

nice work! just some small stuff. The test is currently failing if you run it multiple times. See #10

Create a test/reset endpoint to reset the database, secured with an environment variable and a JWT.

What are thoughts on this approach?

Agree we need a strategy for that, for now this setup is sufficient for the single test that we have. It's out of scope for this PR, there are some good ways (session storage, multiple workers etc.) that we can discuss.

Just by adding this simple registration/login flow test, we already protected ourself from non-obvious failing releases.

I already created a setup with basic playwright fixtures. PR coming soon!

@sjaghori sjaghori merged commit dceacb5 into main Jun 17, 2024
@sjaghori sjaghori deleted the feat_e2e-registration+login-flow branch June 17, 2024 06:46
@sjaghori
Copy link
Collaborator Author

@benjaminstrasser please make sure you add the data-testid's for the components in #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants