(feat) projects overview page by benjaminstrasser · Pull Request #84 · codingcommons/tiny-tms

benjaminstrasser · 2024-06-04T20:34:07Z

~~Depends on #77~~

mledl

Really nice work - our first page 💯
I think we can discuss how we handle state in the path.

src/routes/(authenticated)/projects/create-project.svelte

src/routes/(authenticated)/projects/project-cards.svelte

benjaminstrasser · 2024-06-08T20:56:19Z

Do we want to add backend integration with this PR or move it to another one to keep each smaller?

benjaminstrasser · 2024-06-17T15:58:54Z

@sjaghori
I will add an e2e test once #98 is merged to allow for multiple e2e tests.

sjaghori

Good job, just some suggestions.

services/src/project/project-service.ts

src/components/container/projects/project-cards.svelte

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

added create project dialog and form Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

…already in use Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

jjnp

Small changes. I'll approve, so you can fix them an merge right away

services/src/project/project-service.ts

src/components/container/auth/schema.ts

src/components/container/projects/create-project-schema.ts

src/routes/(authenticated)/projects/+page.server.ts

src/components/container/projects/project-cards-layout.svelte

services/src/project/project-service.unit.test.ts

services/src/error/index.ts

e2e/specs/create-project-flow.spec.ts

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

benjaminstrasser · 2024-07-03T08:54:00Z

@jjnp @sjaghori

In my opinion, this PR is complete. Would love a last look to see if everything checks out. The only remaining feedback concerns error handling and logging. Since the PR is already larger than desired, I suggest we create separate issues for logging and error handling. This way, we can implement these in the currently implemented features (auth, projects) more coherently and independently.

sjaghori

Good Job! 🚀

services/src/error/index.ts

benjaminstrasser requested a review from mledl as a code owner June 4, 2024 20:34

benjaminstrasser marked this pull request as draft June 4, 2024 20:34

benjaminstrasser mentioned this pull request Jun 4, 2024

Basic UI Components #85

Open

4 tasks

benjaminstrasser changed the base branch from main to sidebar June 5, 2024 16:16

benjaminstrasser changed the title ~~Projects Overview Page~~ (feat) projects overview page Jun 6, 2024

Base automatically changed from sidebar to main June 7, 2024 12:56

benjaminstrasser force-pushed the projects-overview branch from a4ffae0 to f86633a Compare June 7, 2024 12:59

mledl reviewed Jun 7, 2024

View reviewed changes

src/routes/(authenticated)/projects/create-project.svelte Outdated Show resolved Hide resolved

src/routes/(authenticated)/projects/create-project.svelte Show resolved Hide resolved

src/routes/(authenticated)/projects/project-cards.svelte Outdated Show resolved Hide resolved

benjaminstrasser force-pushed the projects-overview branch 7 times, most recently from 174adaf to ee253c1 Compare June 16, 2024 13:35

benjaminstrasser marked this pull request as ready for review June 16, 2024 14:04

benjaminstrasser force-pushed the projects-overview branch from 58f0939 to a4377b1 Compare June 16, 2024 14:07

sjaghori mentioned this pull request Jun 17, 2024

(feat): adds e2e test with registration and login workflow #97

Merged

benjaminstrasser mentioned this pull request Jun 18, 2024

added playwright fixture to reset db #98

Merged

sjaghori reviewed Jun 19, 2024

View reviewed changes

benjaminstrasser added 8 commits June 30, 2024 13:20

Added header to projects

8f4366e

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

added basic card layout and design

8fb54c3

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

added basic navigation

29251b3

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

added popover to project card

547cb8a

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

added shadcn dialog

383e43d

added create project dialog and form Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

fixed type errors in autogenerated dialog component

6bd620b

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

removed unnecesarry comment

6c552fa

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

added description to create project dialog

e2a9a57

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

benjaminstrasser added 7 commits June 30, 2024 13:23

added project backend functionality

dc7729e

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

added getAllProjects to repository

37f7c7b

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

added getAllProject to porject service

7c041d3

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

added getAllProjects to frontend

c12ceee

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

fixed timezone issue

0472b7a

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

rearranged route components into components/container folder

e009a35

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

added empty projects view

c4da4da

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

benjaminstrasser force-pushed the projects-overview branch from fa107c2 to c4da4da Compare June 30, 2024 11:27

benjaminstrasser requested a review from jjnp as a code owner June 30, 2024 11:27

added e2e test to create project

f0e547e

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

benjaminstrasser mentioned this pull request Jun 30, 2024

Add user profiles to project overview #106

Open

benjaminstrasser added 3 commits July 1, 2024 15:27

moved project card into seperate component

b0a86a8

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

fixed a bug with language codes and added user form error if name is …

959733c

…already in use Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

imporved grid layout

55f86cd

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

benjaminstrasser mentioned this pull request Jul 1, 2024

use human-readable project IDs instead of numerical IDs in projects paths #109

Open

jjnp previously approved these changes Jul 1, 2024

View reviewed changes

feedback

6e0899c

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

benjaminstrasser dismissed jjnp’s stale review via 6e0899c July 2, 2024 12:01

added domain model for Project

0f7315f

Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>

benjaminstrasser force-pushed the projects-overview branch from bb28056 to 0f7315f Compare July 3, 2024 09:02

benjaminstrasser mentioned this pull request Jul 4, 2024

(feat) 100: account page #101

Merged

benjaminstrasser enabled auto-merge (squash) July 4, 2024 13:43

sjaghori approved these changes Jul 4, 2024

View reviewed changes

services/src/error/index.ts Show resolved Hide resolved

benjaminstrasser merged commit bfd71df into main Jul 5, 2024

benjaminstrasser deleted the projects-overview branch July 5, 2024 07:07

Conversation

benjaminstrasser commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mledl left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benjaminstrasser commented Jun 8, 2024

Uh oh!

benjaminstrasser commented Jun 17, 2024

Uh oh!

sjaghori left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jjnp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benjaminstrasser commented Jul 3, 2024

Uh oh!

sjaghori left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

benjaminstrasser commented Jun 4, 2024 •

edited

Loading

mledl left a comment •

edited

Loading