Skip to content

(feat) sidebar - #77

Merged
benjaminstrasser merged 10 commits into
mainfrom
sidebar
Jun 7, 2024
Merged

(feat) sidebar#77
benjaminstrasser merged 10 commits into
mainfrom
sidebar

Conversation

@benjaminstrasser

@benjaminstrasser benjaminstrasser commented May 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Added a sidebar for the authenticated section of the site.
Also added the following blank pages, which can be navigated to via the sidebar

/projects
/projects/[id]/keys
/projects/[id]/languages
/projects/[id]/settings
/projects/[id]/translations

Depends on #74

@benjaminstrasser
benjaminstrasser requested a review from mledl as a code owner May 31, 2024 21:43
@benjaminstrasser benjaminstrasser mentioned this pull request May 31, 2024
Closed
jjnp
jjnp approved these changes Jun 2, 2024
View reviewed changes

@jjnp jjnp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. We might down the line end up changing some stuff, but I don't see why we'd start predicting the future with the PR^^ Let's merge!

jjnp
jjnp requested changes Jun 2, 2024
View reviewed changes

@jjnp jjnp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gibt ein paar kleinere Issues, review folgt.

@benjaminstrasser

benjaminstrasser commented Jun 2, 2024

Copy link
Copy Markdown
Member Author

ran
git rebase --onto main auth-redesign sidebar
after #74 was merged. This no longer depends on #74

sjaghori
sjaghori requested changes Jun 2, 2024
View reviewed changes

@sjaghori sjaghori left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Comment thread src/routes/(authenticated)/+layout.svelte Outdated
Comment thread src/routes/(authenticated)/+layout.svelte Outdated
Comment thread src/routes/(authenticated)/projects/[id]/+layout.ts
sjaghori
sjaghori previously approved these changes Jun 3, 2024
View reviewed changes

@sjaghori sjaghori left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better

Comment thread src/components/sidebar/sidebar.svelte Outdated
Comment thread src/routes/(authenticated)/+layout.svelte Outdated
Comment thread src/routes/(authenticated)/projects/+page.svelte
@benjaminstrasser benjaminstrasser mentioned this pull request Jun 3, 2024
Merged
sjaghori
sjaghori previously approved these changes Jun 3, 2024
View reviewed changes
@benjaminstrasser benjaminstrasser mentioned this pull request Jun 3, 2024
Open
@jjnp
jjnp self-requested a review June 4, 2024 15:20
@benjaminstrasser
added sidebar
cd96015 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
Sidebar is collapsable
f3b2461 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
Sidebar state is now synced with localstorage
e3cb4ea 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
Changed sidebar communciation to use load functions
d4a5884 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
Moved Sidebar into component
66564af 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
Added profile page
8ed583e 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
redirect signed in users to /projects + after sign in
d9e4ba0 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
added lang postcss to style stags using @apply
58fa35e 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser
added localStorageWritable to sidebar
b1cf740 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser benjaminstrasser mentioned this pull request Jun 4, 2024
Merged
@benjaminstrasser
fixed bug where themeselector navigated to profile page
c1fc0c6 
Signed-off-by: Benjamin Strasser <bp.strasser@gmail.com>
@benjaminstrasser benjaminstrasser changed the title (feat) Sidebar (feat) sidebar Jun 6, 2024
mledl
mledl approved these changes Jun 6, 2024
View reviewed changes

@mledl mledl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most things have been said. A really solid starting point 🚀
Let's go with this, since things will change along the way anyways.

Comment thread src/components/sidebar/sidebar.svelte
@benjaminstrasser

benjaminstrasser commented Jun 7, 2024

Copy link
Copy Markdown
Member Author

@mledl and I agreed to move the theme discussion into another PR. @sajaghori @jjnp any open issues that still need some work?

jjnp
jjnp approved these changes Jun 7, 2024
View reviewed changes
Comment thread src/routes/(authenticated)/+layout.svelte Outdated
Comment thread src/routes/(authenticated)/+layout.svelte Outdated
Comment thread src/routes/(authenticated)/+layout.svelte Outdated
@benjaminstrasser
benjaminstrasser merged commit cf5e59e into main Jun 7, 2024
@benjaminstrasser
benjaminstrasser deleted the sidebar branch June 7, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mledl mledl mledl approved these changes
@jjnp jjnp jjnp approved these changes
@sjaghori sjaghori sjaghori left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@benjaminstrasser @jjnp @mledl @sjaghori