fix: add puppeteer dependency and fix snapshot naming #8822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
tristandubbeld
merged commit cbd991c
into
tristan/csb-678-get-rid-of-selenium-webdriver-dependency
8 of 11 checks passed
tristandubbeld
deleted the
tristan/csb-679-fix-failing-snapshot-tests
branch
tristandubbeld
added a commit
that referenced
this pull request
Nov 12, 2025
…8821) * chore: remove unused browser tests and selenium-webdriver dependency - Remove browsers.test.js which was added for IE11 testing - IE11, iOS, and Android tests were already skipped - Firefox and Safari tests required selenium-webdriver which is not installed - Fixes CI failure: Cannot find module 'selenium-webdriver' * fix: add puppeteer dependency and fix snapshot naming (#8822) * chore: add puppeteer dependency for integration tests * fix: ensure snapshot identifiers include -snap suffix * test: update integration test snapshots * test: increase snapshot thresholds to account for OS rendering differences * chore: bump CircleCI cache version to v39 to invalidate stale caches * fix: use correct jest-image-snapshot API for percentage thresholds * chore: comment customDiffConfig and add logging to be sure it runs correctly * fix: update thresholds to account for OS rendering diffs * fix: snapshot threshold override * fix: update snapshot threshold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Integration tests were failing with:
Cannot find module 'puppeteer'error-snapsuffix)Solution
puppeteerto devDependencies (matches CI version 18.1.0)-snapsuffixImpact