Skip to content

Commit 9754826

Browse files
chore: remove unused browser tests and selenium-webdriver dependency (#8821)
* chore: remove unused browser tests and selenium-webdriver dependency - Remove browsers.test.js which was added for IE11 testing - IE11, iOS, and Android tests were already skipped - Firefox and Safari tests required selenium-webdriver which is not installed - Fixes CI failure: Cannot find module 'selenium-webdriver' * fix: add puppeteer dependency and fix snapshot naming (#8822) * chore: add puppeteer dependency for integration tests * fix: ensure snapshot identifiers include -snap suffix * test: update integration test snapshots * test: increase snapshot thresholds to account for OS rendering differences * chore: bump CircleCI cache version to v39 to invalidate stale caches * fix: use correct jest-image-snapshot API for percentage thresholds * chore: comment customDiffConfig and add logging to be sure it runs correctly * fix: update thresholds to account for OS rendering diffs * fix: snapshot threshold override * fix: update snapshot threshold
1 parent ddb9099 commit 9754826

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

46 files changed

+159
-173
lines changed

.circleci/config.yml

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ aliases:
3333

3434
- &restore_deps_cache
3535
keys:
36-
- v38-dependency-cache-{{ .Branch }}-{{ checksum "yarn.lock" }}
37-
- v38-dependency-cache-{{ .Branch }}
38-
- v38-dependency-cache
36+
- v39-dependency-cache-{{ .Branch }}-{{ checksum "yarn.lock" }}
37+
- v39-dependency-cache-{{ .Branch }}
38+
- v39-dependency-cache
3939

4040
- &save_deps_cache
41-
key: v38-dependency-cache-{{ .Branch }}-{{ checksum "yarn.lock" }}
41+
key: v39-dependency-cache-{{ .Branch }}-{{ checksum "yarn.lock" }}
4242
paths:
4343
- node_modules
4444
- packages/app/node_modules
@@ -63,40 +63,40 @@ aliases:
6363

6464
- &restore_standalone_deps_cache
6565
keys:
66-
- v38-standalone-dependency-cache-{{ .Branch }}-{{ checksum
66+
- v39-standalone-dependency-cache-{{ .Branch }}-{{ checksum
6767
"standalone-packages/codesandbox-browserfs/yarn.lock" }}
68-
- v38-standalone-dependency-cache-{{ .Branch }}
69-
- v38-standalone-dependency-cache
68+
- v39-standalone-dependency-cache-{{ .Branch }}
69+
- v39-standalone-dependency-cache
7070

7171
- &save_standalone_deps_cache
7272
key:
73-
v38-standalone-dependency-cache-{{ .Branch }}-{{ checksum
73+
v39-standalone-dependency-cache-{{ .Branch }}-{{ checksum
7474
"standalone-packages/codesandbox-browserfs/yarn.lock" }}
7575
paths:
7676
- standalone-packages/codesandbox-browserfs/node_modules
7777

7878
- &restore_prod_result
7979
key:
80-
v38-prod-build-result-{{ .Environment.CIRCLE_BRANCH
80+
v39-prod-build-result-{{ .Environment.CIRCLE_BRANCH
8181
}}-{{.Environment.CIRCLE_SHA1 }}
8282

8383
- &save_prod_build_cache
8484
key:
85-
v38-prod-build-cache-{{ .Environment.CIRCLE_BRANCH
85+
v39-prod-build-cache-{{ .Environment.CIRCLE_BRANCH
8686
}}-{{.Environment.CIRCLE_SHA1 }}
8787
paths:
8888
- packages/app/node_modules/.cache
8989

9090
- &restore_prod_build_cache
9191
keys:
92-
- v38-prod-build-cache-{{ .Environment.CIRCLE_BRANCH
92+
- v39-prod-build-cache-{{ .Environment.CIRCLE_BRANCH
9393
}}-{{.Environment.CIRCLE_SHA1 }}
94-
- v38-prod-build-cache-{{ .Environment.CIRCLE_BRANCH }}-
95-
- v38-prod-build-cache-master-
94+
- v39-prod-build-cache-{{ .Environment.CIRCLE_BRANCH }}-
95+
- v39-prod-build-cache-master-
9696

9797
- &save_prod_result
9898
key:
99-
v38-prod-build-result-{{ .Environment.CIRCLE_BRANCH }}-{{
99+
v39-prod-build-result-{{ .Environment.CIRCLE_BRANCH }}-{{
100100
.Environment.CIRCLE_SHA1 }}
101101
paths:
102102
- ./www
@@ -139,14 +139,14 @@ commands:
139139
steps:
140140
- restore_cache:
141141
keys:
142-
- v38-source-cache-{{ .Branch }}-{{ .Revision }}
143-
- v38-source-cache-{{ .Branch }}-
144-
- v38-source-cache-
142+
- v39-source-cache-{{ .Branch }}-{{ .Revision }}
143+
- v39-source-cache-{{ .Branch }}-
144+
- v39-source-cache-
145145

146146
- checkout
147147

148148
- save_cache:
149-
key: v38-source-cache-{{ .Branch }}-{{ .Revision }}
149+
key: v39-source-cache-{{ .Branch }}-{{ .Revision }}
150150
paths:
151151
- '.git'
152152
build_deps:

packages/app/integration-tests/browser-tests/browsers.test.js

Lines changed: 0 additions & 130 deletions
This file was deleted.
130 Bytes
1.47 KB
10.3 KB
838 Bytes
4.45 KB
2.98 KB
7.51 KB
697 Bytes

0 commit comments

Comments
 (0)