Tab icon status #738
Merged
Tab icon status #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why it failed at building the docker image 🤔 |
|
This is great @alexvcasillas, thanks for this PR! |
|
Thanks to you @CompuIves !! |
|
I'm glad to have you on board! :D
I will deploy this somewhere later today!
…On Mon, Apr 16, 2018 at 12:16 PM Alex Casillas ***@***.***> wrote:
Thanks to you @CompuIves <https://github.com/CompuIves> !!
So exciting and proud to be part of this project even if it's with a small
change like this :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#738 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAj1CMf2_P0XcSsaUjZeJQr-hakdmEgTks5tpG98gaJpZM4TWMBO>
.
|
|
Looking forward to see it live : ) |
This was referenced Jan 20, 2021
This was referenced Jan 21, 2021
This was referenced Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
What is the current behavior?
Behavior is described at the following Issue: [UX/UI Suggestion] Close icon on tab #674
What is the new behavior?
The new behavior now works as we discussed at the issue. Let me show you with some screenshots:
When there are changes not synced :)
When I hover this tab now it shows the cross icon replacing the not synced dot :)
If there's just one tab, I respect the original state by just showing the not synced icon even I'm hover or not :)
Checklist:
Hope everything is ok, @CompuIves 👍