[UX/UI Suggestion] Close icon on tab

[alexvcasillas]

Hello @CompuIves !

I've been playing around with CodeSandbox and saw this "issue" that is related to the UI and UX more than business logic :)

If you have pending changes on the file and you hover it's tab, it doesn't show up the cross icon (x) to close that tab as if the file has no changes. When you click on the dot that displays that there are changes pending to be saved, then the tab dissapears.

As the sceenshot doesn't show the current mouse position, it's right on top of the package.json tab.

Also suggest that if I have only one tab active, it won't show the cross icon (x) to close this tab :)

It's a silly issue, but for UX/UI I find it as an interesting suggestion to be reported : )

[CompuIves]

Ah, that's an interesting one. I copied this logic over from vscode.

When you click on the dot that displays that there are changes pending to be saved, then the tab dissapears.

I think we should just disable the close icon when the module is unsaved, does that make sense?

Also suggest that if I have only one tab active, it won't show the cross icon (x) to close this tab :)

Good one, I like this!

Would you be interested in opening a PR for this? 😄

[alexvcasillas]

If the module is unsaved and we get the mouse hover the tab we should replace the dot icon with the cross icon, so even though it's unsaved, the action will be closing this unsaved tab so, the close icon it's more likely to be there : )
And yeah, for sure, I would be interested in PR-ing this : )

[CompuIves]

That's even better! Good suggestion.

[alexvcasillas]

PR #738 😄

[alexvcasillas]

Solved with #738 :)