Skip to content

Conversation

@SaraVieira
Copy link
Contributor

@SaraVieira SaraVieira commented Apr 19, 2020

Issue:

When you are abroad and/or your browser is configured in another language TS will go bananas and use another language to show errors even though all the rest of the errors are in English.

It's a weird experience that I could see on my wife's computer. All her computer is in English but the moment firefox was in Spanish you would get two different languages showing up in the errors.

All of the UI is in English and more commonly than not this is a mistake or a travel issue where people have some setting in the browser misconfigured.

Not to mention that Dank Mono does not support cyrlic so things get WEIRD

This sets all TS errors to be in English always so no more weird things like this happen

Closes #1870
Closes #3676
Closes #3923

@lbogdan
Copy link
Contributor

lbogdan commented Apr 19, 2020

Build for latest commit 0d27cc2 is at https://pr3943.build.csb.dev/s/new.

@CompuIves CompuIves merged commit f303c22 into master Apr 20, 2020
@CompuIves CompuIves deleted the make-en-ts-error branch April 20, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to change errors language? Do not translate if translation was not requested but the user TypeScript errors in another language when abroad

5 participants