Skip to content

Updated French translation #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2021
Merged

Updated French translation #22

merged 2 commits into from
Jul 31, 2021

Conversation

mathieugp
Copy link
Contributor

New and improved French translation. :-)

@mathieugp mathieugp requested review from rngadam and carms-ng July 14, 2021 17:26
@mathieugp
Copy link
Contributor Author

mathieugp commented Jul 14, 2021 •
edited by carms-ng
Loading

@Carms-dev : Some issues I notice from the preview:

  • "Assemble the team based on your problem. Convert dollars to value right away." never gets translated
  • same for "Continual improvement to develop a tailored. sustainable and scallable solution."
  • "Consolidez vos budgets de RH et de TI towards direct actions to solve your problems." is half right. ;-)
  • Line 42 of /locales/fr/index.json as French on both sides of :

@carms-ng
Copy link
Contributor

@Carms-dev : Some issues I notice from the preview:

  • "Assemble the team based on your problem. Convert dollars to value right away." never gets translated
  • same for "Continual improvement to develop a tailored. sustainable and scallable solution."
  • "Consolidez vos budgets de RH et de TI towards direct actions to solve your problems." is half right. ;-)
  • Line 42 of /locales/fr/index.json as French on both sides of :

@mathieugp I think it's all fixed! Can you double check? Please merge if it's looks good!

carms-ng
carms-ng reviewed Jul 30, 2021
View reviewed changes
Copy link
Contributor

@carms-ng carms-ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

@mathieugp mathieugp merged commit 8f053e9 into main Jul 31, 2021
@mathieugp mathieugp deleted the updated-fr-translation branch July 31, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carms-ng carms-ng carms-ng approved these changes

@rngadam rngadam Awaiting requested review from rngadam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieugp @carms-ng