Skip to content

Conversation

@JJ
Copy link
Collaborator

@JJ JJ commented May 10, 2018

Goes to #20, don't know if this is what you had in mind. Feel free to review, add or eliminate.

JJ added 3 commits May 10, 2018 11:43
If you install it locally, it will run Hugo as long as you modify
anything in the `content` directory. If you use it within Travis,
something else will have to be done if it's not deployed to GitHub,
like adding API keys or say where it's going to be deployed.

Addresses issue codeisscience#20. Maybe closes it, but I'm not sure.
@yochannah yochannah self-assigned this May 10, 2018
@yochannah
Copy link
Collaborator

Nice! I'll review after the demo call in a minute :)

JJ added 2 commits May 10, 2018 12:17
Ripping links from the codeisscience#18 comments. Addresses that issue, will be
added to the PR, I guess.

Also adds *~ to .gitignore 🙈
@yochannah yochannah merged commit 6ff9167 into codeisscience:master May 10, 2018
@yochannah
Copy link
Collaborator

@JJ omg, loving the best practices page!!

@JJ
Copy link
Collaborator Author

JJ commented May 10, 2018 via email

@yochannah
Copy link
Collaborator

I've just enabled travis for this repo, maybe that was needed...

@yochannah
Copy link
Collaborator

hmmmm, I triggered a build and it failed: https://travis-ci.com/yochannah/code-is-science thoughts?

@stain88
Copy link

stain88 commented May 10, 2018

Could it be failing because there's no .travis.yml file in the repo?

@yochannah
Copy link
Collaborator

@stain88 I think you might be right. Do you know what to change to fix this, by any chance?

@stain88
Copy link

stain88 commented May 10, 2018

None whatsoever, I'm afraid. Haven't used travis before.
Could always start by creating an empty file, and see what happens 😅

@JJ
Copy link
Collaborator Author

JJ commented May 10, 2018 via email

@yochannah
Copy link
Collaborator

it's deploying to github and hosted on github pages - does that help?

@JJ
Copy link
Collaborator Author

JJ commented May 10, 2018 via email

@yochannah
Copy link
Collaborator

I see! It took a while for me to understand what was happening here. Thank you!

It might be nice to automatically commit and deploy the built site, though. Will continue this in #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants