Skip to content

Minor fix for docs #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Minor fix for docs #421

merged 2 commits into from
Sep 5, 2022

Conversation

arif-rh
Copy link
Contributor

@arif-rh arif-rh commented Sep 5, 2022

This should close PR #419 and close PR #420

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@datamweb datamweb added the documentation Improvements or additions to documentation label Sep 5, 2022
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 👍

We have very interesting statistics of Shield installation and visits.
But I always wonder why these visitors and users don't give us stars.
@arif-rh You have contributed to the improvement of the Shield, may I ask why you did not give the Shield a star?

@kenjis kenjis merged commit 67b14ad into codeigniter4:develop Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants