simplify docs in quickstart - managing user #419
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
reviewed
Sep 5, 2022
docs/quickstart.md
Outdated
| @@ -254,8 +254,7 @@ if ($user->inGroup('admin', 'beta')) { | |||
|
|
|||
| ## Managing Users | |||
|
|
|||
| Shield uses a more complex user setup than many other systems, separating [User Identities](concepts.md#identities) from the user accounts themselves. This quick overview should help you feel more confident when working with users on a day-to-day basis. | |||
| Since Shield uses a more complex user setup than many other systems, due to the [User Identities](concepts.md#user-identities), this quick overview should help you feel more confident when working with users on a day-to-day basis. | |||
| Since Shield uses a more complex user setup than many other systems, separating [User Identities](concepts.md#identities) from the user accounts themselves, this quick overview should help you feel more confident when working with users on a day-to-day basis. | |||
There was a problem hiding this comment.
Suggested change
| Since Shield uses a more complex user setup than many other systems, separating [User Identities](concepts.md#identities) from the user accounts themselves, this quick overview should help you feel more confident when working with users on a day-to-day basis. | |
| Since Shield uses a more complex user setup than many other systems, separating [User Identities](concepts.md#user-identities) from the user accounts themselves, this quick overview should help you feel more confident when working with users on a day-to-day basis. |
|
Please sign your commit. |
|
@kenjis sorry for missing signed commit before. Is the latest signed commit enough, or should I create new PR with only signed commit? |
|
We need all your commits to be signed. You don't need to create new PR, but if it is difficult to sign all commits in this PR, |
arif-rh
force-pushed
the
docs-quickstart
branch
from
6f310a4 to
29fce40
Compare
arif-rh
force-pushed
the
docs-quickstart
branch
from
29fce40 to
4bd436b
Compare
Merged
|
Closed by #421 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove repeated explanation.