Skip to content

fix: Bootstrap column on mobile #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2022
Merged

fix: Bootstrap column on mobile #287

merged 1 commit into from
Jul 11, 2022

Conversation

ThibautPV
Copy link
Contributor

@ThibautPV ThibautPV commented Jul 6, 2022 •
edited by kenjis
Loading

Fixes #271

MGatner
MGatner approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The number of times this layout structure is repeated makes me think we probably need to change our view hierarchies. Beyond the scope of this PR though - thanks for the fix!

@MGatner MGatner linked an issue Jul 6, 2022 that may be closed by this pull request
Display Form on mobile phones #271
Closed
@ThibautPV
Copy link
Contributor Author

Hi @MGatner and thank you for the approval

Indeed, I also think that it is possible to reduce this duplicated code, but I don't know what would be the best way to do it

In the "layout.php" file maybe?

@kenjis
Copy link
Member

kenjis commented Jul 11, 2022

Before:
Screenshot 2022-07-11 18 01 58
Screenshot 2022-07-11 18 02 08
Screenshot 2022-07-11 18 02 14

After:
Screenshot 2022-07-11 18 01 10
Screenshot 2022-07-11 18 01 21
Screenshot 2022-07-11 18 01 27

kenjis
kenjis approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
LGTM!

@kenjis kenjis merged commit e6ad293 into codeigniter4:develop Jul 11, 2022
@kenjis kenjis changed the title fix : Bootstrap column on mobile fix: Bootstrap column on mobile Jul 11, 2022
@kenjis kenjis added the bug Something isn't working label Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display Form on mobile phones
3 participants
@ThibautPV @kenjis @MGatner