Display Form on mobile phones

[ThibautPV]

There is a problem with the display of forms on cell phones. (see attached images)

Indeed, it should be modified :

• class="card col-5 shadow-sm"

With:

• class="card col-12 col-md-5 shadow-sm"

The views "login", "register", "magic_link_message" and "magic_link_form" are concerned

Before :

After :

I also wonder if it would be necessary to add a "class="row"" div after the container?

[MGatner]

Feel free to send over a PR!

add a "class="row"" div after the container

What would this accomplish?

[ThibautPV]

Well, I tried, and I made a mess of it...

The commit put himself in the other pull request : #272

See : develop...ThibautPV:shield:develop

I think I should have "closed" the current pull request before making a new one?

I don't know if there is a solution to fix this.
Delete the fork and re-create it?

I'm not a developer and I don't know how to use Github, I'll have to learn ;)

[kenjis]

You can try:
https://github.com/codeigniter4/shield/edit/develop/src/Views/login.php
Select "Create a new branch for this commit and start a pull request"

[datamweb]

@ThibautPV I know starting to learn anything you don't know can be confusing and scary at the beginning
Like you, I struggled a lot to start learning git, besides, considering that my mother tongue is not English, learning git became many times more difficult for me.
I have now recorded this 12-minute video for you, where you can see how to create new branch, commit and submit PR.
Finally, you can create PR related to commit e70f4f after viewing it.
Remember, my goal is to help you get on the path to learning, so you shouldn't depend on me or anyone else.
I hope this video will help you in learning git.

[kenjis]

Yes, if you want to learn git, learning git commands (and concepts behind them) is the best way.

[ThibautPV]

@datamweb @kenjis : Thank you very much for your help.

Pull Request done :) I let you check that it's ok.

I understood the principle. So I have to create a new branch for each new pull request I make.

I have a question though. How can I be sure that I am working on the last version of the file before committing?
Because when I made the French translation, some modifications had already been made to the original file and I had to start again

Thanks a lot!

[kenjis]

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#pushing-your-branch

If you have any questions, feel free to ask.

[datamweb]

I have a question though. How can I be sure that I am working on the last version of the file before committing?

You must update branch develop first before creating a new branch.
You can do it through the following commands:

> git switch develop
> git fetch upstream
> git merge upstream/develop
> git push origin develop

After updating, create your new branch.
Everything you need is explained here.
If you do not understand by reading it, let me know for further guidance.

[ThibautPV]

Ok perfect !

Thanks for you help