-
Notifications
You must be signed in to change notification settings - Fork 137
Add French translations #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @ThibautPV , please check: |
Hi @datamweb Can you tell me if it's ok now please? It's seem some checks were not successful.. |
All code must conform to our Style Guide, which is based on PSR-12. @ThibautPV So just run: > composer cs-fix Note : If you are interested to know more, please read CodeIgniter Coding Style Guide. |
Ok perfect :) Thanks @datamweb |
@ThibautPV Oh! you have not translated the latest version of the language file. |
@datamweb : Pfff... Sorry... I think it's ok now |
@ThibautPV looks mostly fine to me. I think you forgot to translate this key: suggestPasswordLength |
Yes,
|
@includebeer @kenjis : Thanks for your feedback It's fixed :) |
Thanks to everyone for improving this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ça fait longtemps que j'ai étudié le français! Ça marche bien.
@ThibautPV The subject of this PR is Add French translations. All the work related to the translation has been done correctly, and the two main members of this PR have confirmed. Commit e70f4fb is unrelated to this PR. Therefore, you should submit the changes related to commit e70f4fb in the new PR. A reminder: please use separate branches for each of your PRs - it will make it easier for you to keep changes separate from each other and from whatever else you are doing with your repository! One thing at a time: A pull request should only contain one change. That does not mean only one commit, but one change - however many commits it took. The reason for this is that if you change X and Y, but send a pull request for both at the same time, we might really want X but disagree with Y, meaning we cannot merge the request. Using the Git-Flow branching model you can create new branches for both of these features and send two requests. |
Hi @datamweb , Sorry, I've never used Git before. Can you tell me if it's ok now? |
@ThibautPV Thank you! |
@ThibautPV no problem. We have all made these mistakes just like you. I am a beginner in git. Here is a very good book that helped me a lot. At this stage, learn the following commands: git config
git status
git remote
git branch
git switch
git add
git commit
git diff
git log
git log --oneline
git reset
git restore
git reset HEAD
git checkout
git push
Everything went well. And this PR is merged. |
Thank you very much for these clarifications 👍 |
If @includebeer sees any changes to be made, don't hesitate.