Skip to content

Add French translations #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 3, 2022
Merged

Add French translations #272

merged 6 commits into from
Jul 3, 2022

Conversation

ThibautPV
Copy link
Contributor

If @includebeer sees any changes to be made, don't hesitate.

@datamweb
Copy link
Collaborator

datamweb commented Jul 2, 2022

Hi @ThibautPV , please check:
#235 (comment)

@ThibautPV
Copy link
Contributor Author

Hi @datamweb

Can you tell me if it's ok now please?

It's seem some checks were not successful..

@datamweb
Copy link
Collaborator

datamweb commented Jul 2, 2022

All code must conform to our Style Guide, which is based on PSR-12.
You can fix most of the coding style violations by running this command in your terminal:

@ThibautPV So just run:

> composer cs-fix

Note : If you are interested to know more, please read CodeIgniter Coding Style Guide.

@ThibautPV
Copy link
Contributor Author

Ok perfect :)

Thanks @datamweb

@datamweb
Copy link
Collaborator

datamweb commented Jul 2, 2022

@ThibautPV Oh! you have not translated the latest version of the language file.
The latest version of the language file is here.
please check it.

@ThibautPV
Copy link
Contributor Author

@datamweb : Pfff... Sorry...

I think it's ok now

@includebeer
Copy link

includebeer commented Jul 2, 2022

@ThibautPV looks mostly fine to me. I think you forgot to translate this key: suggestPasswordLength

@kenjis
Copy link
Member

kenjis commented Jul 2, 2022

Yes, suggestPasswordLength test fails.

$ composer test
> phpunit
PHPUnit 9.5.21 #StandWithUkraine

Runtime:       PHP 8.0.20
Configuration: /Users/kenji/work/codeigniter/codeigniter-shield/phpunit.xml
Random Seed:   1656797994

...............F...............................................  63 / 199 ( 31%)
............................................................... 126 / 199 ( 63%)
............................................................... 189 / 199 ( 94%)
..........                                                      199 / 199 (100%)

Nexus\PHPUnit\Extension\Tachycardia identified these 3 slow tests:
+--------------------------------------------------------------------------+---------------+-------------+
| Test Case                                                                | Time Consumed | Time Limit  |
+--------------------------------------------------------------------------+---------------+-------------+
| Tests\\Controllers\\RegisterTest::testRegisterActionSuccess              | 00:00:00.94   | 00:00:00.50 |
| Tests\\Controllers\\RegisterTest::testRegisterRedirectsToActionIfDefined | 00:00:00.93   | 00:00:00.50 |
| Tests\\Unit\\DictionaryValidatorTest::testCheckTrueOnNotFound            | 00:00:00.82   | 00:00:00.50 |
+--------------------------------------------------------------------------+---------------+-------------+


Time: 00:13.260, Memory: 42.00 MB

There was 1 failure:

1) Tests\Language\FrenchTranslationTest::testAllIncludedLanguageKeysAreTranslated with data set "fr" ('fr')
Failed asserting that the translated language key "Auth.suggestPasswordLength" in "fr" locale differs from the original keys in the main repository.
Failed asserting that an array is empty.

/Users/kenji/work/codeigniter/codeigniter-shield/tests/Language/AbstractTranslationTestCase.php:255

FAILURES!
Tests: 199, Assertions: 462, Failures: 1.
Script phpunit handling the test event returned with error code 1

@ThibautPV
Copy link
Contributor Author

@includebeer @kenjis : Thanks for your feedback

It's fixed :)

@datamweb
Copy link
Collaborator

datamweb commented Jul 3, 2022

Thanks to everyone for improving this PR.
@ThibautPV Merci beaucoup.

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ça fait longtemps que j'ai étudié le français! Ça marche bien.

@datamweb
Copy link
Collaborator

datamweb commented Jul 3, 2022

@ThibautPV The subject of this PR is Add French translations. All the work related to the translation has been done correctly, and the two main members of this PR have confirmed.

Commit e70f4fb is unrelated to this PR. Therefore, you should submit the changes related to commit e70f4fb in the new PR.

A reminder: please use separate branches for each of your PRs - it will make it easier for you to keep changes separate from each other and from whatever else you are doing with your repository!

One thing at a time: A pull request should only contain one change. That does not mean only one commit, but one change - however many commits it took. The reason for this is that if you change X and Y, but send a pull request for both at the same time, we might really want X but disagree with Y, meaning we cannot merge the request. Using the Git-Flow branching model you can create new branches for both of these features and send two requests.
Note : please read Branching

@ThibautPV
Copy link
Contributor Author

Hi @datamweb ,

Sorry, I've never used Git before.

Can you tell me if it's ok now?

@kenjis kenjis merged commit d234619 into codeigniter4:develop Jul 3, 2022
@kenjis
Copy link
Member

kenjis commented Jul 3, 2022

@ThibautPV Thank you!

@datamweb
Copy link
Collaborator

datamweb commented Jul 4, 2022

Sorry, I've never used Git before.

@ThibautPV no problem. We have all made these mistakes just like you. I am a beginner in git.
Recently, with the help of @kenjis , I have been on the path of learning it.
Also, don't worry, everyone here will help you to get on the right track to learn it according to the level of expertise and free time they have, you just need to be interested.

Here is a very good book that helped me a lot.
And there is good content here too.
Also here is the Git documentation in French.
I suggest you start with it and the videos on YouTube.

At this stage, learn the following commands:

git config
git status
git remote
git branch
git switch
git add
git commit
git diff
git log
git log --oneline
git reset
git restore
git reset HEAD
git checkout
git push

Can you tell me if it's ok now?

Everything went well. And this PR is merged.

@ThibautPV
Copy link
Contributor Author

Thank you very much for these clarifications 👍

@kenjis kenjis added the lang Languages file label Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang Languages file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants