Skip to content
This repository was archived by the owner on Nov 5, 2022. It is now read-only.

Updates to the Ruleset #31

Closed
wants to merge 8 commits into from
Closed

Updates to the Ruleset #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1ec3c13
Increase Line lenght to 250
najdanovicivan Dec 1, 2020
32e45a5
Function parameter Comment - Do not enforce capital letter
najdanovicivan Dec 1, 2020
f1dfbf4
Function @throws comment - Do not enforce dot at the end
najdanovicivan Dec 1, 2020
8e48499
Function @throws comment - Do not enforce capital letter
najdanovicivan Dec 1, 2020
11096b5
Function @throws Comment - Make comment optional
najdanovicivan Dec 1, 2020
05f261c
Version 1.0.2
najdanovicivan Dec 1, 2020
9830451
File Comment - Do not require @package, @author, @license
najdanovicivan Dec 1, 2020
a66c365
Class Comment - Do not require @package
najdanovicivan Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
composer.phar
composer.lock
/vendor/
/build
phpunit.xml
2 changes: 1 addition & 1 deletion CodeIgniter4/Sniffs/Commenting/ClassCommentSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class ClassCommentSniff extends FileCommentSniff
*/
protected $tags = array(
'@package' => array(
'required' => true,
'required' => false,
'allow_multiple' => false,
),
'@subpackage' => array(
Expand Down
6 changes: 3 additions & 3 deletions CodeIgniter4/Sniffs/Commenting/FileCommentSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class FileCommentSniff implements Sniff
*/
protected $tags = array(
'@package' => array(
'required' => true,
'required' => false,
'allow_multiple' => false,
),
'@subpackage' => array(
Expand All @@ -45,15 +45,15 @@ class FileCommentSniff implements Sniff
'allow_multiple' => false,
),
'@author' => array(
'required' => true,
'required' => false,
'allow_multiple' => true,
),
'@copyright' => array(
'required' => false,
'allow_multiple' => true,
),
'@license' => array(
'required' => true,
'required' => false,
'allow_multiple' => false,
),
'@link' => array(
Expand Down
14 changes: 13 additions & 1 deletion CodeIgniter4/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,21 @@
Methods and functions MUST have a doc block comment.
-->
<rule ref="Squiz.Commenting.FunctionComment"/>
<rule ref="Squiz.Commenting.FunctionComment.ParamCommentNotCapital">
<severity>0</severity>
</rule>
<rule ref="Squiz.Commenting.FunctionComment.ParamCommentFullStop">
<severity>0</severity>
</rule>
<rule ref="Squiz.Commenting.FunctionComment.EmptyThrows">
<severity>0</severity>
</rule>
<rule ref="Squiz.Commenting.FunctionComment.ThrowsNotCapital">
<severity>0</severity>
</rule>
<rule ref="Squiz.Commenting.FunctionComment.ThrowsNoFullStop">
<severity>0</severity>
</rule>
<!--
Doc block comment alignment.
-->
Expand Down Expand Up @@ -213,7 +225,7 @@
-->
<rule ref="Generic.Files.LineLength">
<properties>
<property name="lineLimit" value="120"/>
<property name="lineLimit" value="250"/>
<property name="absoluteLineLimit" value="0"/>
</properties>
</rule>
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "codeigniter4/codeigniter4-standard",
"type": "phpcodesniffer-standard",
"description": "CodeIgniter 4 Standard for PHP_CodeSniffer 3.",
"version":"1.0.1",
"version":"1.0.2",
"license":"MIT",
"authors": [
{
Expand Down
Loading