Skip to content
This repository was archived by the owner on Nov 5, 2022. It is now read-only.

Updates to the Ruleset #31

Closed
wants to merge 8 commits into from

Conversation

najdanovicivan
Copy link

Some updates done to the rule set

  • Line length increased to 250 characters
  • Function @param comment - Do not enforce capital letter
  • Function @throws comment - Do not enforce dot at the end
  • Function @throws comment - Do not enforce capital letter
  • Function @throws comment - Makes it optional

File and Class comment rule changes. This is because mostly all of the existing files are missing those. We can either disable those for now and I can go latter on and update every file

  • @Package I don't know if we need it it should be first namespace level under CodeIgniter
  • @Licence - We can link the license in every file
  • @author - Can be added from the git commit logs

With all of these I increased the version to 1.0.2

@paulbalandan
Copy link
Member

  • @Package I don't know if we need it it should be first namespace level under CodeIgniter
  • @Licence - We can link the license in every file
  • @author - Can be added from the git commit logs

These are no longer needed since we are using the short header format.

@najdanovicivan
Copy link
Author

  • @Package I don't know if we need it it should be first namespace level under CodeIgniter
  • @Licence - We can link the license in every file
  • @author - Can be added from the git commit logs

These are no longer needed since we are using the short header format.

Ok then. I've already disabled those so this one is ready to be merged

@najdanovicivan
Copy link
Author

I also removed the composer.lock file and added it to .gitignore as test was failing

@louisl louisl changed the base branch from master to develop March 4, 2021 12:22
@louisl louisl mentioned this pull request Mar 5, 2021
@louisl
Copy link
Collaborator

louisl commented Mar 5, 2021

Thanks @najdanovicivan, closing this as I had to pull those changes in separately to a more recent version.

@louisl louisl closed this Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants