Skip to content

Enable php_unit_data_provider_static #7767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2023
Merged

Enable php_unit_data_provider_static #7767

merged 1 commit into from
Aug 4, 2023

Conversation

paulbalandan
Copy link
Member

Description
To be forward-compatible with PHPUnit 10.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

MGatner
MGatner approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that was easy enough. PHPUnit 10 here we come!

@paulbalandan paulbalandan merged commit 152a7a1 into codeigniter4:develop Aug 4, 2023
@paulbalandan paulbalandan deleted the phpunit-data-provider-static branch August 4, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @kenjis @MGatner