Merge pull request #7767 from paulbalandan/phpunit-data-provider-static

Enable `php_unit_data_provider_static`

Author: paulbalandan

.php-cs-fixer.dist.php

@@ -48,6 +48,7 @@
         'prefix' => 'provide',
         'suffix' => '',
     ],
+    'php_unit_data_provider_static'      => true,
     'php_unit_data_provider_return_type' => true,
     'no_extra_blank_lines'               => [
         'tokens' => [

.php-cs-fixer.no-header.php

@@ -34,6 +34,7 @@
         'prefix' => 'provide',
         'suffix' => '',
     ],
+    'php_unit_data_provider_static'      => true,
     'php_unit_data_provider_return_type' => true,
     'no_extra_blank_lines'               => [
         'tokens' => [

.php-cs-fixer.user-guide.php

@@ -53,7 +53,8 @@
             'use',
         ],
     ],
-    'php_unit_data_provider_name' => [
+    'php_unit_data_provider_static' => true,
+    'php_unit_data_provider_name'   => [
         'prefix' => 'provide',
         'suffix' => '',
     ],

tests/system/CLI/CLITest.php

@@ -463,7 +463,7 @@ public function testTable($tbody, $thead, $expected): void
         $this->assertSame($this->getStreamFilterBuffer(), $expected);
     }
 
-    public function provideTable(): iterable
+    public static function provideTable(): iterable
     {
         $head = [
             'ID',

tests/system/Cache/Handlers/BaseHandlerTest.php

@@ -35,7 +35,7 @@ public function testValidateKeyInvalidType($input): void
         BaseHandler::validateKey($input);
     }
 
-    public function provideValidateKeyInvalidType(): iterable
+    public static function provideValidateKeyInvalidType(): iterable
     {
         return [
             [true],

tests/system/Cache/Handlers/FileHandlerTest.php

@@ -296,7 +296,7 @@ public function testSaveMode(int $int, string $string): void
         $this->assertSame($string, $mode);
     }
 
-    public function provideSaveMode(): iterable
+    public static function provideSaveMode(): iterable
     {
         return [
             [

tests/system/CodeIgniterTest.php

@@ -789,7 +789,7 @@ public function testPageCacheWithCacheQueryString($cacheQueryStringValue, int $e
         CITestStreamFilter::removeErrorFilter();
     }
 
-    public function providePageCacheWithCacheQueryString(): iterable
+    public static function providePageCacheWithCacheQueryString(): iterable
     {
         $testingUrls = [
             'test', // URL #1

tests/system/Commands/CommandTest.php

@@ -138,7 +138,7 @@ public function testCommandParsesArgsCorrectly(string $input, array $expected):
         $this->assertSame($expected, ParamsReveal::$args);
     }
 
-    public function provideCommandParsesArgsCorrectly(): iterable
+    public static function provideCommandParsesArgsCorrectly(): iterable
     {
         return [
             [

tests/system/Commands/Utilities/Routes/SampleURIGeneratorTest.php

@@ -33,7 +33,7 @@ public function testGet(string $routeKey, string $expected): void
         $this->assertSame($expected, $uri);
     }
 
-    public function provideGet(): iterable
+    public static function provideGet(): iterable
     {
         yield from [
             'root'                => ['/', '/'],

tests/system/CommonFunctionsTest.php

@@ -604,7 +604,7 @@ public function testCleanPathActuallyCleaningThePaths($input, $expected): void
         $this->assertSame($expected, clean_path($input));
     }
 
-    public function provideCleanPathActuallyCleaningThePaths(): iterable
+    public static function provideCleanPathActuallyCleaningThePaths(): iterable
     {
         $ds = DIRECTORY_SEPARATOR;