Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix transactions.rst #6919

Merged
merged 5 commits into from
Nov 29, 2022
Merged

docs: fix transactions.rst #6919

merged 5 commits into from
Nov 29, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 27, 2022 •
edited
Loading

Description
Fixes #6916

  • fix old wrong description
  • improve "Managing Errors" explanation
  • small improvements

Related: #6917, #6886, #6912

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Nov 27, 2022
@kenjis kenjis mentioned this pull request Nov 28, 2022
Merged
2 tasks
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 28, 2022
@kenjis
Copy link
Member Author

kenjis commented Nov 28, 2022

@codeigniter4/database-team
I have some transaction-related PRs,
but please review this fix for the current docs first.

This was referenced Nov 28, 2022
Merged
Merged
@kenjis kenjis added the database Issues or pull requests that affect the database layer label Nov 28, 2022
@kenjis kenjis merged commit cd7f3a6 into codeigniter4:develop Nov 29, 2022
@kenjis kenjis deleted the fix-docs-transactions branch November 29, 2022 23:58
@kenjis
Copy link
Member Author

kenjis commented Nov 29, 2022

@michalsn Thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DB Transactions description for Strict Mode
2 participants
@kenjis @michalsn