test: add DB transaction tests #6912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Nov 27, 2022
All the current DB drivers throw Exception when a query error occurs. See codeigniter4#6912 MySQLi driver sets `mysqli_report(MYSQLI_REPORT_ALL & ~MYSQLI_REPORT_INDEX)` that throws mysqli_sql_exception. SQLite3 and Postgres drivers throw ErrorException because of Error Handler. SQLSRV driver has different implementaion. It throws DatabaseException when the query return value is false.
kenjis
added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Nov 27, 2022
All the current DB drivers throw an exception when a query error occurs. See codeigniter4#6912 MySQLi driver sets `mysqli_report(MYSQLI_REPORT_ALL & ~MYSQLI_REPORT_INDEX)` that throws mysqli_sql_exception. SQLite3 and Postgres drivers throw ErrorException because of Error Handler. SQLSRV driver has different implementaion. It throws DatabaseException when the query return value is false.
kenjis
added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Nov 27, 2022
All the current DB drivers throw an exception when a query error occurs. See codeigniter4#6912 MySQLi driver sets `mysqli_report(MYSQLI_REPORT_ALL & ~MYSQLI_REPORT_INDEX)` that throws mysqli_sql_exception. SQLite3, Postgres and OCI8 drivers throw ErrorException because of Error Handler. SQLSRV driver has different implementaion. It throws DatabaseException when the query return value is false.
3 tasks
mackxpall
approved these changes
Nov 27, 2022
kenjis
added a commit
to kenjis/CodeIgniter4
that referenced
this pull request
Nov 30, 2022
All the current DB drivers throw an exception when a query error occurs. See codeigniter4#6912 MySQLi driver sets `mysqli_report(MYSQLI_REPORT_ALL & ~MYSQLI_REPORT_INDEX)` that throws mysqli_sql_exception. SQLite3, Postgres and OCI8 drivers throw ErrorException because of Error Handler. SQLSRV driver has different implementaion. It throws DatabaseException when the query return value is false.
|
This PR just adds test code. |
paulbalandan
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is tests for v4.2.
Related #6919, #6886
See https://github.com/codeigniter4/CodeIgniter4/actions/runs/3555886311/jobs/5972871727 to see Exception classes.
The current behaviors:
mysqli_report(MYSQLI_REPORT_ALL & ~MYSQLI_REPORT_INDEX)that throwsmysqli_sql_exception.ErrorExceptionbecause of Error Handler.Exceptionwhen the query return value is false.Checklist: