Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for test result ingestion in the CLI #347

Merged
merged 16 commits into from
Jan 25, 2024
Merged

Add support for test result ingestion in the CLI #347

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0e34b92
feat: add test result file finding in FileFinder
joseph-sentry Dec 29, 2023
fc18ff4
chore: change coverage_files to files in UploadCollectionResult
joseph-sentry Dec 29, 2023
9579928
feat: update upload collector to handle test result files
joseph-sentry Dec 29, 2023
3f92c81
feat: update upload senders to handle test result files
joseph-sentry Dec 29, 2023
fee768c
feat: add report type option and rename coverage files options to files
joseph-sentry Dec 29, 2023
06d2abc
chore: make lint
joseph-sentry Jan 3, 2024
85f00f8
chore: fix failing tests
joseph-sentry Jan 3, 2024
e8908d2
tests: add tests for test_results
joseph-sentry Jan 3, 2024
d24e5a9
fix: fix file finder excluded patterns
joseph-sentry Jan 3, 2024
03dbb10
tests: update file finder tests
joseph-sentry Jan 3, 2024
83bd89f
tests: add tests for generate_upload_data
joseph-sentry Jan 3, 2024
9b0b7d6
fix: move url and data choice to separate function in upload sender
joseph-sentry Jan 23, 2024
4cbc86b
fix: no more prep plugins in test results upload
joseph-sentry Jan 24, 2024
098683a
fix: pass report type to file finder constructor
joseph-sentry Jan 24, 2024
255b211
chore: make lint
joseph-sentry Jan 24, 2024
bc18658
test: fix tests due to prep plugin and file finder changes
joseph-sentry Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: fix tests due to prep plugin and file finder changes 
Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
  • Loading branch information
@joseph-sentry
joseph-sentry committed Jan 25, 2024
commit bc1865892fd298e38779b4f236713d0e57fbf144
16 changes: 7 additions & 9 deletions tests/services/upload/test_upload_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def test_do_upload_logic_happy_path_legacy_uploader(mocker):
mock_select_preparation_plugins.assert_called_with(
cli_config, ["first_plugin", "another", "forth"]
)
mock_select_file_finder.assert_called_with(None, None, None, False)
mock_select_file_finder.assert_called_with(None, None, None, False, "coverage")
mock_select_network_finder.assert_called_with(versioning_system)
mock_generate_upload_data.assert_called_with("coverage")
mock_send_upload_data.assert_called_with(
Expand Down Expand Up @@ -167,7 +167,7 @@ def test_do_upload_logic_happy_path(mocker):
mock_select_preparation_plugins.assert_called_with(
cli_config, ["first_plugin", "another", "forth"]
)
mock_select_file_finder.assert_called_with(None, None, None, False)
mock_select_file_finder.assert_called_with(None, None, None, False, "coverage")
mock_select_network_finder.assert_called_with(versioning_system)
mock_generate_upload_data.assert_called_with("coverage")
mock_send_upload_data.assert_called_with(
Expand Down Expand Up @@ -241,7 +241,7 @@ def test_do_upload_logic_dry_run(mocker):
enterprise_url=None,
)
out_bytes = parse_outstreams_into_log_lines(outstreams[0].getvalue())
mock_select_file_finder.assert_called_with(None, None, None, False)
mock_select_file_finder.assert_called_with(None, None, None, False, "coverage")
mock_select_network_finder.assert_called_with(versioning_system)
assert mock_generate_upload_data.call_count == 1
assert mock_send_upload_data.call_count == 0
Expand Down Expand Up @@ -392,7 +392,7 @@ def side_effect(*args, **kwargs):
mock_select_preparation_plugins.assert_called_with(
cli_config, ["first_plugin", "another", "forth"]
)
mock_select_file_finder.assert_called_with(None, None, None, False)
mock_select_file_finder.assert_called_with(None, None, None, False, "coverage")
mock_select_network_finder.assert_called_with(versioning_system)
mock_generate_upload_data.assert_called_with("coverage")
mock_upload_completion_call.assert_called_with(
Expand Down Expand Up @@ -464,7 +464,7 @@ def side_effect(*args, **kwargs):
mock_select_preparation_plugins.assert_called_with(
cli_config, ["first_plugin", "another", "forth"]
)
mock_select_file_finder.assert_called_with(None, None, None, False)
mock_select_file_finder.assert_called_with(None, None, None, False, "coverage")
mock_select_network_finder.assert_called_with(versioning_system)
mock_generate_upload_data.assert_called_with("coverage")

Expand Down Expand Up @@ -529,10 +529,8 @@ def test_do_upload_logic_happy_path_test_results(mocker):
]

assert res == UploadSender.send_upload_data.return_value
mock_select_preparation_plugins.assert_called_with(
cli_config, ["first_plugin", "another", "forth"]
)
mock_select_file_finder.assert_called_with(None, None, None, False)
mock_select_preparation_plugins.assert_not_called
mock_select_file_finder.assert_called_with(None, None, None, False, "test_results")
mock_select_network_finder.assert_called_with(versioning_system)
mock_generate_upload_data.assert_called_with("test_results")
mock_send_upload_data.assert_called_with(
Expand Down
Loading