Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for test result ingestion in the CLI #347

Merged
merged 16 commits into from
Jan 25, 2024

Conversation

joseph-sentry
Copy link
Contributor

@joseph-sentry joseph-sentry commented Jan 3, 2024

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f3827b3) 95.52% compared to head (bc18658) 95.94%.

Files Patch % Lines
codecov_cli/commands/upload_process.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
+ Coverage   95.52%   95.94%   +0.42%     
==========================================
  Files          80       81       +1     
  Lines        2746     2788      +42     
==========================================
+ Hits         2623     2675      +52     
+ Misses        123      113      -10     
Flag Coverage Δ
python3.10 96.23% <96.66%> (+0.47%) ⬆️
python3.11 96.23% <96.66%> (+0.47%) ⬆️
python3.8 96.23% <96.66%> (+0.47%) ⬆️
python3.9 96.23% <96.66%> (+0.47%) ⬆️
smart-labels 95.94% <96.66%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joseph-sentry joseph-sentry force-pushed the joseph/test-results branch 2 times, most recently from 023f970 to de08e38 Compare January 3, 2024 17:25
@joseph-sentry joseph-sentry marked this pull request as ready for review January 17, 2024 20:45
@@ -66,9 +67,17 @@ def send_upload_data(
headers = get_token_header_or_fail(token)
encoded_slug = encode_slug(slug)
upload_url = enterprise_url or CODECOV_API_URL
url = f"{upload_url}/upload/{git_service}/{encoded_slug}/commits/{commit_sha}/reports/{report_code}/uploads"
if upload_file_type == "coverage":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] move this to a separate function

@@ -134,6 +137,10 @@
"*.zip",
]

test_results_files_excluded_patterns = (
coverage_files_patterns + coverage_files_excluded_patterns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart

@joseph-sentry
Copy link
Contributor Author

latest push was just to sign all the commits

@joseph-sentry joseph-sentry merged commit be85cc8 into main Jan 25, 2024
18 checks passed
@joseph-sentry joseph-sentry deleted the joseph/test-results branch January 25, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants