Skip to content

Split alphanumeric encoding from QRCodeGenerator, split encoding tables #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 2, 2025
Merged

Split alphanumeric encoding from QRCodeGenerator, split encoding tables #590

merged 13 commits into from
Jun 2, 2025

Conversation

Shane32
Copy link
Contributor

@Shane32 Shane32 commented Apr 6, 2025 •
edited
Loading

Refactoring for readability, maybe as prep to add Micro QR code support; no functional changes; no public API changes. Also made a few other inconsequential changes; see notes below.

Note that tests are not all passing locally for me anymore, probably due to PNG encoding not being stable across .NET versions/frameworks

@Shane32 Shane32 changed the title Split QRCodeGenerator further Splits QR table constants into a separate file Apr 6, 2025
@Shane32 Shane32 marked this pull request as ready for review April 6, 2025 16:19
@Shane32 Shane32 marked this pull request as draft April 6, 2025 16:19
@Shane32 Shane32 marked this pull request as ready for review April 6, 2025 18:24
@Shane32 Shane32 changed the title Splits QR table constants into a separate file Split alphanumeric encoding from QRCodeGenerator, split encoding tables Apr 7, 2025
Shane32
Shane32 commented Apr 7, 2025
View reviewed changes
Shane32
Shane32 commented Apr 7, 2025
View reviewed changes
Shane32
Shane32 commented Apr 7, 2025
View reviewed changes
Shane32
Shane32 commented Apr 7, 2025
View reviewed changes
Shane32
Shane32 commented Apr 7, 2025
View reviewed changes
@Shane32
Copy link
Contributor Author

Shane32 commented Apr 12, 2025

@codebude Ready for review please. This is pretty basic refactoring, further code-splitting QRCodeGenerator.cs and improving readability. The goal is to be able to cleanly add the Micro QR code tables into CapacityTables.cs in a future PR without affecting any existing functionality.

@Shane32 Shane32 requested a review from gfoidl April 12, 2025 04:30
@Shane32 Shane32 mentioned this pull request Apr 13, 2025
Open
gfoidl
gfoidl approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@gfoidl gfoidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little calc-simplification, otherwise LGTM (codewise, I don't know these constants good enough to judge about them).

@Shane32 @gfoidl
Update QRCoder/QRCodeGenerator/GaloisField.cs
faac596 
Co-authored-by: Günther Foidl <gue@korporal.at>
Shane32
Shane32 commented Apr 16, 2025
View reviewed changes
@codebude codebude merged commit 04cb78b into codebude:master Jun 2, 2025
4 checks passed
@codebude
Copy link
Owner

codebude commented Jun 2, 2025

Thanks for your ongoing support @Shane32 @gfoidl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebude codebude codebude approved these changes

@gfoidl gfoidl gfoidl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shane32 @codebude @gfoidl