-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Micro QR code support #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
M2 codes will generate correctly now |
Still a little more work to do, but it appears to be generating readable codes for all micro QR code sizes now. |
Co-authored-by: Günther Foidl <gue@korporal.at>
This implementation is complete. I might add some more tests but everything is working. |
@Shane32 please merge the master-branch in your micro-branch, so that the latest changes are in and the diff becomes smaller for review 😉. IIRC GitHub doesn't do that automatically. |
I've merged it, but it looks like the CI scripts are failing again... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestion to the code.
For the logic about micro QR code I can't tell very much, here I trust @Shane32.
Co-authored-by: Günther Foidl <gue@korporal.at>
Co-authored-by: Günther Foidl <gue@korporal.at>
Co-authored-by: Günther Foidl <gue@korporal.at>
Co-authored-by: Günther Foidl <gue@korporal.at>
Thanks @gfoidl ! |
CI scripts have been fixed - @codebude can you review? |
Hey @codebude do you have a little time to review this PR? |
Prerequisites (to reduce diff):
Status:
Side notes: