-
-
Notifications
You must be signed in to change notification settings - Fork 22
Update pull_request_template.md #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b581948
Update pull_request_template.md
lpatmo eb82450
Update .github/pull_request_template.md
lpatmo ae672db
Update .github/pull_request_template.md
lpatmo 71a5611
Update .github/pull_request_template.md
lpatmo 4d08c2c
Update .github/pull_request_template.md
lpatmo 7513d5f
Update .github/pull_request_template.md
lpatmo 96a00ba
Update .github/pull_request_template.md
lpatmo 2bbbce8
Update .github/pull_request_template.md
lpatmo b65c256
Update .github/pull_request_template.md
lpatmo e24ddde
Update .github/pull_request_template.md
lpatmo 598f15c
Update .github/pull_request_template.md
lpatmo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,71 @@ | ||
### Background/Context | ||
## What type of PR is this? (check all applicable) | ||
|
||
### Before and After | ||
- [ ] 🐛 Bug Fix | ||
- [ ] ✨ Feature (_**e.g.** API change, enhancement, addition, etc._) | ||
- [ ] ♻️ Refactor | ||
- [ ] 📝 Documentation | ||
- [ ] 🔖 Release | ||
lpatmo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
- [ ] 🚩 Other (**concerning:** ) | ||
|
||
### Acknowledgments (optional) | ||
## Context | ||
|
||
### Other notes (optional) | ||
**_Placeholder example below:_** | ||
|
||
Closes Issue #128 | ||
|
||
Right now, on the front-end, we need to pass in a token (i.e. the user needs to be logged in) before they can see a list of resource. | ||
|
||
``` | ||
axios | ||
.get('/api/v1/resources', { | ||
headers: { | ||
Authorization: `Bearer ${authContext.authTokens.token}`, | ||
}, | ||
}) | ||
``` | ||
|
||
This should be true for when users are creating a resource, but the list of resources on https://cb-react-concept.netlify.com/resources should be available to the public. | ||
|
||
## Other Related Tickets & Documents (as needed) | ||
|
||
**_Placeholder example:_** This relates to issue #23, and I also filed issue #43 as a next step to do after this PR is merged. | ||
|
||
## Implementation Details | ||
What was your thought process as you changed the code? What does someone need to consider in reviewing it? | ||
|
||
Placeholder example: | ||
|
||
Placeholder example: | ||
[x] Made GET /resources not protected by authorization | ||
[x] Changed setup for tests to make sure we're not authed for the GET requests, but are authed for POST, PATCH, and search. | ||
[x] Added test to make sure GET /api/v1/resources/{{guid}}/ and GET /api/v1/resources/ requests and search work without a token | ||
[x] Altered tests for GET GET /api/v1/resources/{{guid}}/ and GET /api/v1/resources/ requests and search to ensure that they also work with a token | ||
[x] Added tests to make sure PATCH and POST fail without a token | ||
[x] Added test to make sure DEL fails without a token | ||
|
||
## New Libraries/Dependancies Introduced (Fill out as needed) | ||
|
||
|
||
If you have added libraries or other dependancies, please list them (and links to their repos) below: | ||
|
||
- [ ] I've updated `requirements.txt` | ||
|
||
## Any new migration files added? | ||
|
||
- [ ] 👍 yes | ||
- [ ] 🙅 no, because they aren't needed | ||
|
||
## Did you add tests? | ||
**_Code added or changed without test coverage or good reason for exemption won't be approved._** | ||
|
||
- [ ] 👍 yes | ||
- [ ] 🙋 no, because I need help | ||
- [ ] 🙅 no, because they aren't needed | ||
|
||
## Did you add documentation? | ||
|
||
- [ ] 📜 readme.md | ||
- [ ] 📜 contributing.md | ||
- [ ] 📜 wiki entry | ||
- [ ] 🙋 I'd like someone to help write documentation, and will file a new issue for it | ||
- [ ] 🙅 no documentation needed |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.