Skip to content

Update pull_request_template.md #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 26, 2020
Merged

Update pull_request_template.md #159

merged 11 commits into from
Aug 26, 2020

Conversation

lpatmo
Copy link
Member

@lpatmo lpatmo commented Aug 22, 2020

Background/Context

Updates the PR template! Context: discussion in #158 (reply in thread)

Before and After

Before:
image

After:
Something closer to this:
image

Acknowledgments (optional)

@BethanyG for the updated draft

Other notes (optional)

N/A

@lpatmo lpatmo requested a review from a team August 22, 2020 17:55
@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@9f7cb65). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage        ?   83.70%           
=======================================
  Files           ?       29           
  Lines           ?      491           
  Branches        ?        0           
=======================================
  Hits            ?      411           
  Misses          ?       80           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f7cb65...598f15c. Read the comment docs.

lpatmo and others added 3 commits August 23, 2020 17:16
Whoa, this "commit suggestion" feature on GitHub is really nice!

Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
@BethanyG
Copy link
Member

Gah. Apologies for the individual delete suggestions. The interface wouldn't let me do a multi-line suggestion there for some reason. The purpose of the re-ordering is to get at what I think might be the most "common" tasks. I also removed "enhancement". I think "enhancements" are more or less a feature, the only difference being the "size" -- i.e., the addition of code that doesn't specifically address a bug. My thinking is the fewer the categories, the easier it is to fill out.

lpatmo and others added 7 commits August 25, 2020 18:29
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
@lpatmo lpatmo merged commit f018ef7 into main Aug 26, 2020
@lpatmo
Copy link
Member Author

lpatmo commented Aug 26, 2020

Thanks @BethanyG for the feedback/commit suggestions!

@lpatmo lpatmo deleted the update-pr-template branch August 26, 2020 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants