Skip to content

Conversation

@despo
Copy link
Member

@despo despo commented Sep 5, 2018

includes translations files added by Crowdin.

@despo despo requested a review from matyikriszta September 5, 2018 19:46
@coveralls
Copy link

coveralls commented Sep 5, 2018

Coverage Status

Coverage decreased (-0.2%) to 90.09% when pulling 0b80d8d on l10n_configure-translations-app into f188077 on master.

select_coach: '- Select Coach -'
tutorial: 'What tutorial did you go through?'
select_tutorial: '- Select Tutorial -'
request: 'How did you find the workshop?'
Copy link
Contributor

@KimberleyCook KimberleyCook Sep 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we need to change the wording of this question as I often I see people reply with the word Google 😂

Or is that the intension!! Maybe I'm wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can approach that in a different PR as the intention of this is just to get in the translation files for all languages.

@despo despo force-pushed the l10n_configure-translations-app branch from 4c782da to e91c654 Compare October 2, 2018 20:24
Copy link
Contributor

@matyikriszta matyikriszta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@despo despo merged commit 0b9d0c3 into master Oct 2, 2018
MarckK pushed a commit to MarckK/planner that referenced this pull request Dec 14, 2018
mroderick added a commit to mroderick/codebar-planner that referenced this pull request Aug 27, 2025
The files were added in
_ codebar#647
- codebar#813

But has not been put to use.

Once we're at Rails 8, we can re-visit if we want to implement
localisation. I'm sure things have moved forwards since this was
introduced in 2018.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants