internationalization (I18n) work #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@despo this is the localization/internationalization work I have started. I've left you a question in the PR description above. |
matyikriszta
force-pushed
the
feature/internationalization
branch
from
eb8c3f7 to
df86629
Compare
|
@despo this PR is currently on 🔥 as tests are failing left and right |
…cally include locales in URLs
… should render the French translation
- stores to cookie
despo
force-pushed
the
feature/internationalization
branch
from
c87cb98 to
f74d3d8
Compare
despo
approved these changes
Jul 25, 2018
MarckK
pushed a commit
to MarckK/planner
that referenced
this pull request
Dec 14, 2018
internationalization (I18n) work
mroderick
added a commit
to mroderick/codebar-planner
that referenced
this pull request
Aug 27, 2025
The files were added in _ codebar#647 - codebar#813 But has not been put to use. Once we're at Rails 8, we can re-visit if we want to implement localisation. I'm sure things have moved forwards since this was introduced in 2018.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the beginning of the internationalization work as per #173. I have added support for en, fr and de translations and it currently supports the French translation of the code of conduct (all other pages fall back to the English version for now). I have decided to go with the
codebar.io/locale/exampleconstruct and use scoped routes. I have added a set_locale method to the application_controller which is required to set the locale. The problem is currently only the code-of-conduct route is wrapped in a scope. set_locale works fine on this URL, e.g. when I changecodebar.io/en/code-of-conducttocodebar.io/fr/code-of-conductit correctly serves the French version, but on all other URLs it appends a?local=enparam to the URL. I would like all other URLs to fall back onto the English version and for the app not to append the param to the URLs. Not sure how to achieve this exactly.Status
Ready to Review
Related Github issue
#173