Feature implementation from commits 1531cf4..3b0c229 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unclear how this happens, possibly a division error? Fixes EssentialsX#6043
On 1.21.4+ Player#updateCommands has the same logic as CraftServer#updateCommands, so we can just use that.
1.21 Adds a new org.bukkit.spawner.Spawner class as a superclass of CreatureSpawner which now contains the setMaxSpawnDelay method. Change our test to look for the method on any superclasses too.
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Adds a new [issue type](https://docs.github.com/en/issues/tracking-your-work-with-issues/configuring-issues/managing-issue-types-in-an-organization) to new issues. Basically built in labels.
This allows EssentialsX Discord to send EssentialsX Chat messages to Discord when `use-essentials-events: true` is set in the Discord config while local chat is disabled. It also allows plugins to hook and modify EssentialsX Chat message contents, formatting and recipients when local chat is disabled.
Need to explicitly enable them in our LegacyComponentSerializer.
can never win with this fixes EssentialsX#6107
Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>
Fixes an issue for API consumers getting Adventure in our exception messages.
Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>
Migrate the few typo fixes from Crowdin's English US translation into the source messages.properties file (which is also English US).
Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com> This PR significantly overhauls the comments of the EssentialsX configuration files, ensuring consistency, clarity, and overall improved grammar (validated by Grammarly and LLMs). There are still a few things that must be completed before this is ready to be merged, but no further significant changes are expected. A couple of options have been moved entirely to make more logical sense, but this will not affect any compatibility.
Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
API Enhancements and New Provider Implementation
Overview
This PR introduces several API enhancements across multiple modules including a nickname regex configuration, user activity tracking, Discord message formatting, and a new command synchronization provider for Bukkit 1.21.4+.
Change Types
Affected Modules
src/main/java/com/earth2me/essentials/ISettings.javasrc/main/java/com/earth2me/essentials/Settings.javasrc/main/java/com/earth2me/essentials/User.javasrc/main/java/com/earth2me/essentials/signs/SignBuy.javasrc/main/java/com/earth2me/essentials/signs/SignSell.javasrc/main/java/com/earth2me/essentials/utils/AdventureUtil.javasrc/main/java/net/essentialsx/discord/DiscordSettings.javaBaseProviders/.../ModernSyncCommandsProvider.javaNotes for Reviewers