Skip to content

Adds full support for socialspy in EssentialsDiscord #5620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JRoy merged 13 commits into from
Mar 24, 2025
Merged

Adds full support for socialspy in EssentialsDiscord #5620

JRoy merged 13 commits into from
Mar 24, 2025

Conversation

@mrbubbles06
Copy link
Contributor

@mrbubbles06 mrbubbles06 commented Jan 23, 2024 •
edited
Loading

Information

This PR closes #5586.

Details

Proposed feature:

Adds support for socialspy (viewing private messages) in EssentialsDiscord.

Environments tested:

OS: MacOS 14.1

Java version: Temurin-17.0.10+7

  • Most recent Paper version (1.20.4, git-Paper-393)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

Demonstration:

image image

@mrbubbles06 mrbubbles06 marked this pull request as ready for review January 23, 2024 08:24
@nelind3
Copy link

nelind3 commented Feb 20, 2024

Looks great (I already ended up making a custom extension to do this because it was so needed for our moderation ability. It would be amazing to have it as a built in). Personally though I'd prefer it if the naming and formatting was more consistent with the rest of EssentialsX and EssentialsXDiscord namely:

  • I think the message formatting should mirror the socialspy formatting. That is instead of {sender-username} -> {receiver-username}: {message} i think [SS][{sender-displayname} -> {receiver-displayname}]: {message} or similar is more appropriate.
  • I think the message type name in the config should be something like socialspy or private-message in the same style as the other message types.

@Bobcat00
Copy link
Contributor

Bobcat00 commented Feb 20, 2024

I think the message formatting should mirror the socialspy formatting. That is instead of {sender-username} -> {receiver-username}: {message} i think [SS][{sender-displayname} -> {receiver-displayname}]: {message} or similar is more appropriate.

I have a PR to make the Social Spy messages configurable to use either the player name or the display name (because player names are so much better for SS messages).

@nelind3
Copy link

nelind3 commented Feb 21, 2024

If that does go through (which it really should display names versus player names are very much a thing that should be configurable) i think the socialspy formatting here should still mirror the in game socialspy formatting and it's defaults. If the default changes to socialspy using player names then this should default to player names too in my opinion. It's essentially the same message they should have the same default formatting.

@Bobcat00
Copy link
Contributor

Bobcat00 commented Feb 21, 2024

I agree. Also, my PR does not change the default being display names.

JRoy
JRoy requested changes Mar 24, 2025
View reviewed changes
JRoy
JRoy requested changes Mar 24, 2025
View reviewed changes
@JRoy
Copy link
Member

JRoy commented Mar 24, 2025

Sorry for the delay in approval and thanks for the contribution :)

@JRoy JRoy merged commit 50b696b into EssentialsX:2.x Mar 24, 2025
1 check passed
Euphillya added a commit to Euphillya/Essentials-Folia that referenced this pull request Jun 27, 2025
@Euphillya
Update Upstream EssentialsX:
1070216 
EssentialsX@40540eb Expose IUser#getLastActivityTime to API (EssentialsX#6101)
EssentialsX@50b696b Adds social spy message type for in EssentialsDiscord (EssentialsX#5620)
EssentialsX@dabe687 Add SignTransactionEvent for buy and sell signs (EssentialsX#6071)
EssentialsX@0cb387f Fix NPE when unlinking offline players (EssentialsX#6111)
EssentialsX@f09541c Update to Minecraft 1.21.5 (EssentialsX#6109)
EssentialsX@c7ff994 Fire GlobalChatEvent even when local chat is disabled (EssentialsX#6113)
EssentialsX@06c886c Fix /baltop on 1.15.2 and below (EssentialsX#6115)
EssentialsX@2bb4438 Fix further trade sign validation mismatches (EssentialsX#6116)
EssentialsX@8455212 Fix /spawnmob on < 1.21.5 (EssentialsX#6121)
EssentialsX@be3e641 New Crowdin updates (EssentialsX#6089)
EssentialsX@3f5b122 Use legacy text for TranslatableException#getMessage (EssentialsX#6134)
EssentialsX@fe43017 Fix heer typo in messages_en.properties (EssentialsX#6135)
EssentialsX@a58db23 Update English source strings with fixes from Crowdin (EssentialsX#6140)
EssentialsX@d137031 Improve config comments & ordering (EssentialsX#6108)
EssentialsX@3b0c229 New Crowdin updates (EssentialsX#6131)
EssentialsX@3fe1495 Fix unexpected behavior with essentials.home.bed & essentials.sethome.bed permissions (EssentialsX#5991)
EssentialsX@aebe851 Fix double messages when deleting a non-existent home (EssentialsX#6150)
EssentialsX@3a5c7c4 Revert changes to /home and /sethome that break bed interactions (EssentialsX#6151)
EssentialsX@3d28d82 Release 2.21.1
EssentialsX@e836747 Prepare for 2.21.2 dev builds (EssentialsX#6128)
EssentialsX@d42347f Fix sending message during /editsign paste if SignChangeEvent is cancelled (EssentialsX#6136)
EssentialsX@997f600 Update adventure dependencies (EssentialsX#6163)
EssentialsX@4057326 Update to Minecraft 1.21.6
EssentialsX@2796399 Add 1.21.6 Mobs
EssentialsX@31ea903 Move tests to MockBukkit
EssentialsX@ff1b8b8 Add 1.21.6 Aliases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JRoy JRoy JRoy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow EssentialsDiscord to "have socialspy"

4 participants

@mrbubbles06 @nelind3 @Bobcat00 @JRoy