Skip to content

Conversation

@codeOwlAI
Copy link
Owner

@codeOwlAI codeOwlAI commented Jun 29, 2025

PR Summary

Enhance Configuration and Compatibility Features

Overview

This PR adds nickname pattern configuration, improves compatibility with older Bukkit versions, and enhances the sign trade validation system.

Change Types

Type Description
Enhancement Added configurable nickname patterns via regex
Bugfix Fixed compatibility with Bukkit versions below 1.15.2
Enhancement Added validation parameter to sign trade operations

Affected Modules

Module / File Change Description
src/main/java/com/earth2me/essentials/Settings.java Added new method getNickRegex() to retrieve allowed nickname patterns
src/main/java/com/earth2me/essentials/commands/Commandbalancetop.java Added VersionUtil import and exception for minimum playtime check on older Bukkit versions
src/main/java/com/earth2me/essentials/signs/SignTrade.java Added validationRun parameter to amount-related methods

Notes for Reviewers

  • Verify that the nickname regex configuration works correctly with custom patterns
  • Confirm that the minimum playtime check correctly skips for Bukkit versions below 1.15.2
  • Test sign trading functionality to ensure the new validation parameter doesn't affect existing behavior

Chew and others added 25 commits March 19, 2025 07:43
This allows EssentialsX Discord to send EssentialsX Chat messages to
Discord when `use-essentials-events: true` is set in the Discord config
while local chat is disabled.

It also allows plugins to hook and modify EssentialsX Chat message
contents, formatting and recipients when local chat is disabled.
Need to explicitly enable them in our LegacyComponentSerializer.
Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>
Fixes an issue for API consumers getting Adventure in our exception messages.
Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>
Migrate the few typo fixes from Crowdin's English US translation into the source messages.properties file (which is also English US).
Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>

This PR significantly overhauls the comments of the EssentialsX configuration files, ensuring consistency, clarity, and overall improved grammar (validated by Grammarly and LLMs). There are still a few things that must be completed before this is ready to be merged, but no further significant changes are expected. A couple of options have been moved entirely to make more logical sense, but this will not affect any compatibility.
Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>
….bed permissions (EssentialsX#5991)

Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.