Add test support for Cloudex #695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsmith
reviewed
Feb 13, 2017
| config :cloudex, :cloudinary_api, Cloudex.CloudinaryApi.Test | ||
| config :cloudex, api_key: "test_key", secret: "test_secret", cloud_name: "test_cloud_name" | ||
|
|
||
| IO.puts("NOTE: No Cloudex configuration found. Cloudex is runnning in test mode.") |
There was a problem hiding this comment.
Is there a way to do this as a warn with a yellow log color.
Also, is this test_key, etc an actual Cloudinary value, or just something we're using?
There was a problem hiding this comment.
It's just a random value. We need to provide a value, any value, or Cloudex raises an error on startup.
begedin
force-pushed
the
cloudex-test-support
branch
2 times, most recently
from
788d9e6 to
390f286
Compare
|
@joshsmith I replaced |
joshsmith
approved these changes
Feb 14, 2017
joshsmith
force-pushed
the
cloudex-test-support
branch
from
390f286 to
ea8524a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR makes it so Cloudex can run in dev and test mode, even if the API keys are missing. Without this, the application will not start in either of the two modes.
I thought we had an issue for this, but I cannot find it. With this and #694, Cloudex should work much better.