Add unit test for CodeCorps.Helpers.CloudinaryUrl and RandomIconColor #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the unit testing, but there's still a piece missing which would allow the test and dev environments to run without the API keys. I'm working on getting that done in #695 Once that's merged, you can rebase from here and the tests should run. We can work on merging it in then. |
|
@Banzay that PR is merged now. Would you be able to rebase onto |
YuriiZdyrko
force-pushed
the
tests-color-cloudinary
branch
from
188244e to
6f0e262
Compare
YuriiZdyrko
force-pushed
the
tests-color-cloudinary
branch
from
6f0e262 to
c9c342c
Compare
Done |
|
This looks good to go. Thank you @Banzay |
begedin
approved these changes
Feb 16, 2017
|
Merging unsquashed because the two commits do different things. |
|
Thanks @Banzay 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for:
lib/code_corps/helpers/cloudinary_url.ex
lib/code_corps/helpers/random_icon_color.ex
Moved
Cloudexto configuration to allow testing.References
Closes #675