Skip to content

test: add file to test stripSuffix (inspired by stripPrefix-test)#290

Merged
miorel merged 2 commits intocode-chronicles-code:mainfrom
elidelima:main
Aug 8, 2024
Merged

test: add file to test stripSuffix (inspired by stripPrefix-test)#290
miorel merged 2 commits intocode-chronicles-code:mainfrom
elidelima:main

Conversation

@elidelima
Copy link
Contributor

Created new file to test stripSuffix utility as requested (#289).

@elidelima elidelima requested a review from miorel as a code owner August 7, 2024 15:09
@miorel
Copy link
Contributor

miorel commented Aug 8, 2024

Thanks for the pull request @elidelima, this looks really good! I appreciate your finding a word with the property like "banana" and also adding a few more tests that are testing things not covered in the stripPrefix version!

We need just a couple of things before this is ready to merge.

  1. Let's get the checks to pass! I believe they are currently complaining because of the formatting -- would you mind running the file through Prettier? You can run yarn format inside the workspaces/util directory to do so. There is a lint warning that will also be fixed by this, as well.

  2. Just to confirm: are you ok with your contribution being distributed under the MIT License?

Thanks again!

@elidelima
Copy link
Contributor Author

Hi @miorel, thank you for the review.

  1. Fixed!
  2. I'm ok with that!

Thanks!

Copy link
Contributor

@miorel miorel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Let me know if you're interested in anything else from this repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants