Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: ui: add confirmation modal for reset SQL Stats #83142

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 21, 2022

Backport 1/1 commits from #83108 on behalf of @maryliag.

/cc @cockroachdb/release


Previously, there was not confirmation when the user
clicked on reset SQL Stats. This commit introduce
a confirmation modal, with a proper warning about
the data about to be deleted.

Fixes #81867

Screen Shot 2022-06-20 at 4 18 51 PM

https://www.loom.com/share/9bd3c6af8f574453ac69e201697601b9

Release note (ui change): Add confirmation modal to reset SQL Stats


Release justification: low risk, high benefit change

Previously, there was not confirmation when the user
clicked on `reset SQL Stats`. This commit introduce
a confirmation modal, with a proper warning about
the data about to be deleted.

Fixes #81867

Release note (ui change): Add confirmation modal to `reset SQL Stats`
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-83108 branch from 708d55e to 074df28 Compare June 21, 2022 18:32
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 21, 2022
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 21, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag requested a review from a team June 22, 2022 15:48
@maryliag maryliag merged commit 7fb1cf5 into release-22.1 Jun 22, 2022
@maryliag maryliag deleted the blathers/backport-release-22.1-83108 branch June 22, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants