ui: add confirmation modal for reset SQL Stats #83108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there was not confirmation when the user clicked on `reset SQL Stats`. This commit introduce a confirmation modal, with a proper warning about the data about to be deleted. Fixes cockroachdb#81867 Release note (ui change): Add confirmation modal to `reset SQL Stats`
|
This change is |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was not confirmation when the user
clicked on
reset SQL Stats. This commit introducea confirmation modal, with a proper warning about
the data about to be deleted.
Fixes #81867
https://www.loom.com/share/9bd3c6af8f574453ac69e201697601b9
Release note (ui change): Add confirmation modal to
reset SQL Stats