Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachprod: default to buffering file sinks in roachprod #133256

Merged
merged 1 commit into from
Oct 23, 2024
Merged

roachprod: default to buffering file sinks in roachprod #133256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pkg/cmd/roachtest/tests/disk_stall.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,6 @@ func runDiskStalledWALFailover(
startOpts.RoachprodOpts.StoreCount = 2
}
startOpts.RoachprodOpts.ExtraArgs = []string{
// Adopt buffering of the file logging to ensure that we don't block on
// flushing logs to the stalled device.
"--log", fmt.Sprintf(`{file-defaults: {dir: "%s", buffered-writes: false, buffering: {max-staleness: 1s, flush-trigger-size: 256KiB, max-buffer-size: 50MiB}}}`, s.LogDir()),
"--wal-failover=" + failoverFlag,
}
c.Start(ctx, t.L(), startOpts, startSettings, c.CRDBNodes())
Expand Down
6 changes: 5 additions & 1 deletion pkg/roachprod/install/files/cockroachdb-logging.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
---
file-defaults:
auditable: false
buffered-writes: true
buffered-writes: false
buffering:
max-staleness: 5s
flush-trigger-size: 256KiB
max-buffer-size: 50MiB
dir: #{ .LogDir #}
exit-on-error: false
filter: INFO
Expand Down
Loading