Add .coafile #42

bekicot · 2018-06-05T16:19:00Z

Fix lint error raised by coala at LICENSE.md && README.md

Closes #31

@blazeu && @jayvdb && @yashovardhanagrawal

nemani · 2018-06-05T16:24:31Z

.travis.yml

@@ -17,11 +17,15 @@ before_install:
  - phantomjs --version

 install:
+  # Coala doesn't discover local packages.


lowercase c in coala

nemani · 2018-06-05T16:24:52Z

I think the commit message needs some changes.

bekicot · 2018-06-05T16:49:43Z

@nemaniarjun And what should it be?

jayvdb · 2018-06-05T17:17:12Z

.yamllint

@@ -0,0 +1,3 @@
+---
+rules:
+  truthy: disable  # The current version of yaml, checking keys.


Why you need this?

The current version of yaml, checking keys. While in travis we use on

https://github.com/adrienverge/yamllint/blob/master/yamllint/rules/truthy.py

"truthy value is not quoted"

easy solution -- quote it.

or use alternative travis syntax to achieve the same effect.

It might also be a bug in yamllint, in which case you should look at yamllint to see if there is an existing issue, and create an issue if it doesnt already exist.

It is upstream bugs. In my opinion.
And not using it for now.

jayvdb · 2018-06-05T17:18:19Z

LICENSE.md

@@ -1,11 +1,15 @@
-                    GNU GENERAL PUBLIC LICENSE
-                       Version 3, 29 June 2007


Fix #41 first

Now #46 (can be an extra commit in this PR)

And now fix #46

You should never modify a LICENSE file, not even to change the syntax.
It must be a verbatim copy of the license from a verifiable source.

I miss understood with extra commits. @blazeu explained

palash25 · 2018-06-05T17:21:54Z

@bekicot its not just a .coafile change there is also a change in the README. I'm not sure if that should be a separate commit but it should at least be reflected in the commit description if you are not going to make it into another commit.

bekicot · 2018-06-05T17:34:15Z

@palash25 Change in README is already explained in commit message as fix

palash25 · 2018-06-05T17:37:05Z

So sorry @bekicot didn't know how I missed that 👍

RaiVaibhav · 2018-06-05T18:08:09Z

.coafile

@@ -0,0 +1,11 @@
+[all]
+ignore = node_modules/**, bower_components/**, dist/**, .eslintrc.js


ignore .git also?

locally coala will run on .git folder also ?

Coala shouldn't check .git. If it does, then it is a bug.

blazeu

Please add ESLintBear

blazeu · 2018-06-11T09:31:05Z

.coafile

+eslint_config = .eslintrc.js
+files = *.js, app/**.js, config/*.js, tests/**.js
+
+[all.ESLintBear]


Should be all.markdown ?

The section name doesn't have to be the bear name

The reason why it shouldn't be the bear name, because we might add more bear into the section.

The reason why we needed the SpaceConsistencyBear to be in a separate section is because it should run on all files and the section name doesn't have to be SpaceConsistencyBear if we want it consistent with the rest of coala repos.

Maybe see https://github.com/coala/community/blob/master/.coafile and https://github.com/coala/gci-leaders/blob/master/.coafile for naming.

ping @jayvdb

(yes, section names shouldnt be bear names as a general rule)

it has been renamed to all.js, so this is good now.

jayvdb · 2018-06-11T13:40:05Z

.travis.yml

-language: node_js
-node_js:
-  - "6"
+language: python


no.
This is a node project, it must have node as its global language.
That is needed so that we can have multiple versions in the global matrix.

You need to create a coala stage which is python, as already requested at #42 (comment) , and you have been given the recipe even in #40 and fixup #55

Was following your suggestion on gitter to follow gci-leaders. I thought you aware of my problem. And offering an easy solution.

I was using jobs and nodejs before and there was an error. Pushed before the hint is suggested.

jayvdb · 2018-06-11T23:43:26Z

needs a rebase.

jayvdb · 2018-06-11T23:54:38Z

.travis.yml

+      script: false
+      after_success: false
+      before_deploy: false
+      deploy: false


use <<: *disable_global, like the example you have been given.

Otherwise the lint job is inaccurately marked as "Node.js: 6 Python 3.6" on the matrix
https://travis-ci.org/coala/git-task-list/builds/391029250

*disable_global Doesn't work, There is a failed build.

https://travis-ci.org/coala/git-task-list/jobs/391031526

I needs before_script global hook.

That log is for the commit
d421a13#diff-354f30a63fb0907d4ad57269548329e3R36
which doesnt use disable_global. And i put a comment on that commit showing why it failed.

jayvdb · 2018-06-11T23:55:36Z

.coafile

+
+[all.yaml]
+bears = YAMLLintBear
+files = **.yml


yaml files also are .yaml

jayvdb · 2018-06-12T00:00:42Z

.coafile

@@ -0,0 +1,27 @@
+[all]
+ignore = node_modules/**, bower_components/**, dist/**, .eslintrc.js, tmp/**,


why is .eslintrc.js ignored globally?

Yes, it raised warning as eslintbear itself won't lint .eslintrc.js. I dont know how to remove the warning. And force lint it, so ignore.
Should be ignored in js, instead of global.

*eslintbear. Not eslint itself

Traceback (most recent call last): File "/Users/bekicot/Library/Python/3.6/lib/python/site-packages/coalib/bears/Bear.py", line 282, in execute return [] if result is None else list(result) File "/usr/local/lib/python3.6/site-packages/bears/js/ESLintBear.py", line 88, in process_output if result['ruleId'] is not None else self) KeyError: 'ruleId'

No suficient knowledge to debug it in timely maner

I also try

./node_modules/eslint --no-ignore --no-color --stdin --stdin-filename=/home/travis/build/coala/git-task-list/.eslintrc.js --config .eslintrc.js < .eslintrc.

it works fine.

GCI Leader seems to have the same problem.

coala --files=git-task-list/.eslintrc.js --bears=ESLintBear -V

I asked you (two comments earlier right here) to push to travis and show me a travis error.
Anyway ... I did it, and now I can see it
https://travis-ci.org/jayvdb/gsoc-prep-tasks/jobs/391075675#L958

I see you did create an issue coala/coala-bears#2533

Now add a comment in your .coafile about that bug.

It is not raised an error, just a warning. It was anoying so i ignored it

jayvdb · 2018-06-12T00:04:00Z

.coafile

+         .git/**
+
+[all.SpaceConsistencyBear]
+files = **.js, **.json, **.yml, **.md, .eslintrc


Executing section all.SpaceConsistencyBear... [WARNING][21:16:59] No files matching '/home/travis/build/coala/git-task-list/.eslintrc' were found.

Will remove, and ignore eslint on js. it is invalid name

jayvdb · 2018-06-12T00:07:34Z

.coafile

+[all.js]
+bears = ESLintBear
+eslint_config = .eslintrc.js
+files = *.js, app/**.js, config/*.js, tests/**.js


Ideally **.js , and using ignore to handle any files which are special cases and should not be linted by this bear.

Hanged in my machine. Not a big deal, i will Use **.js

jayvdb · 2018-06-12T01:50:59Z

.travis.yml

@@ -33,6 +33,22 @@ jobs:
      install: pip install moban
      script: .ci/check_moban.sh

+    - stage: lint


You have not used disable_global as requested, or given a reason why it wont work.

jayvdb · 2018-06-12T03:12:15Z

.coafile

+ignore = node_modules/**, bower_components/**, dist/**, tmp/**, .git/**
+
+[all.SpaceConsistencyBear]
+files = **.js, **.json, **.yml, **.md, .eslintrc.js


You do not need to add .eslintrc.js

I removed it, and it was included because of **.js

see https://travis-ci.org/jayvdb/gsoc-prep-tasks/jobs/391075675#L741

jayvdb · 2018-06-12T03:32:11Z

.coafile

+eslint_config = .eslintrc.js
+files = **.js
+# See https://github.com/coala/coala-bears/issues/2533
+ignore = .eslintrc.js


The existing ignore rules are being discard here.

use

ignore += .eslintrc.js

stale

jayvdb

Two of the commits use Fixes: .. instead of Fixes ...

Fixes coala#46

remove insert_final_newline for hbs file in .enditorconfig Fixes coala#53

Add a coala's job Fix lint error in README.md Add remark packages to package.json Closes coala#31

nemani reviewed Jun 5, 2018

View reviewed changes

bekicot force-pushed the add-coafile branch 3 times, most recently from ce9b76f to cbaa7c7 Compare June 5, 2018 17:11

jayvdb requested changes Jun 5, 2018

View reviewed changes

jayvdb added the blocked label Jun 5, 2018

bekicot force-pushed the add-coafile branch 2 times, most recently from e141856 to 688699b Compare June 5, 2018 17:19

bekicot force-pushed the add-coafile branch from 688699b to bba684f Compare June 5, 2018 17:25

bekicot force-pushed the add-coafile branch 5 times, most recently from 538dde8 to a7a3ccb Compare June 5, 2018 18:02

RaiVaibhav reviewed Jun 5, 2018

View reviewed changes

bekicot force-pushed the add-coafile branch 3 times, most recently from 713800f to fba142c Compare June 5, 2018 19:55

jayvdb added process/wip and removed blocked labels Jun 7, 2018

blazeu previously requested changes Jun 7, 2018

View reviewed changes

bekicot force-pushed the add-coafile branch 4 times, most recently from d1b49c9 to a5f515a Compare June 8, 2018 01:42

blazeu reviewed Jun 11, 2018

View reviewed changes

bekicot force-pushed the add-coafile branch from 89fa527 to 4d0adee Compare June 11, 2018 10:06

blazeu requested a review from jayvdb June 11, 2018 11:46

jayvdb requested changes Jun 11, 2018

View reviewed changes

bekicot force-pushed the add-coafile branch from 7528f27 to aceb083 Compare June 11, 2018 21:09

bekicot force-pushed the add-coafile branch 2 times, most recently from 4642bbf to 772f1b7 Compare June 11, 2018 23:52

jayvdb reviewed Jun 11, 2018

View reviewed changes

jayvdb requested changes Jun 12, 2018

View reviewed changes

bekicot force-pushed the add-coafile branch 3 times, most recently from eafd181 to 58d5e38 Compare June 12, 2018 01:43

jayvdb reviewed Jun 12, 2018

View reviewed changes

bekicot force-pushed the add-coafile branch 2 times, most recently from 2893e8f to f55b4b2 Compare June 12, 2018 02:12

jayvdb reviewed Jun 12, 2018

View reviewed changes

bekicot force-pushed the add-coafile branch 2 times, most recently from 4219ffd to a3ef738 Compare June 12, 2018 03:17

jayvdb reviewed Jun 12, 2018

View reviewed changes

bekicot force-pushed the add-coafile branch from a3ef738 to ed11319 Compare June 12, 2018 03:33

jayvdb approved these changes Jun 12, 2018

View reviewed changes

jayvdb requested changes Jun 12, 2018

View reviewed changes

bekicot added 3 commits June 12, 2018 11:17

Rename LICENSE.md to LICENSE

bbf7e54

Fixes coala#46

.editorconfig: Remove hbs rule

41cb49a

remove insert_final_newline for hbs file in .enditorconfig Fixes coala#53

Add .coafile

90117fb

Add a coala's job Fix lint error in README.md Add remark packages to package.json Closes coala#31

bekicot force-pushed the add-coafile branch from ed11319 to 90117fb Compare June 12, 2018 04:17

jayvdb approved these changes Jun 12, 2018

View reviewed changes

jayvdb merged commit 90117fb into coala:master Jun 12, 2018

		@@ -1,11 +1,15 @@
		GNU GENERAL PUBLIC LICENSE
		Version 3, 29 June 2007

		@@ -0,0 +1,11 @@
		[all]
		ignore = node_modules/, bower_components/, dist/**, .eslintrc.js

		@@ -0,0 +1,27 @@
		[all]
		ignore = node_modules/, bower_components/, dist/, .eslintrc.js, tmp/,

Add .coafile #42

Add .coafile #42

Uh oh!

Conversation

bekicot commented Jun 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nemani commented Jun 5, 2018

Uh oh!

bekicot commented Jun 5, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bekicot Jun 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jayvdb Jun 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

palash25 commented Jun 5, 2018

Uh oh!

bekicot commented Jun 5, 2018

Uh oh!

palash25 commented Jun 5, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RaiVaibhav Jun 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blazeu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bekicot Jun 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jayvdb commented Jun 11, 2018

Uh oh!

jayvdb Jun 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bekicot commented Jun 5, 2018 •

edited

Loading

bekicot Jun 7, 2018 •

edited

Loading

jayvdb Jun 7, 2018 •

edited

Loading

RaiVaibhav Jun 5, 2018 •

edited

Loading

bekicot Jun 11, 2018 •

edited

Loading

jayvdb Jun 11, 2018 •

edited

Loading

bekicot Jun 12, 2018 •

edited

Loading

bekicot Jun 12, 2018 •

edited

Loading