Use gitignore moban #40
Conversation
.gitignore
Outdated
|
|
||
| # ember-try |
There was a problem hiding this comment.
We could pull in the .gitignore from https://github.com/ember-cli/ember-try , but it would be better to push that to https://github.com/github/gitignore
There was a problem hiding this comment.
It looks like https://github.com/ember-cli/ember-cli/blob/master/blueprints/app/files/gitignore
and/or https://github.com/ember-cli/ember-try/blob/master/.gitignore are the source files.
MIT while the gitignore repo is CC-0 .
jayvdb
force-pushed
the
moban
branch
2 times, most recently
from
ed808f7 to
cc7a7d6
Compare
| [Ll]ib | ||
| [Ll]ib64 | ||
| [Ll]ocal | ||
| [Ss]cripts |
There was a problem hiding this comment.
Why we want to ignore this in a JS project?
Although I may never add Scripts directory, but it seems like other people have a valid usage for it. (e.g Custom build scripts)
There was a problem hiding this comment.
Well, I thought it is only required in python project.
There was a problem hiding this comment.
It is required in a python project, but it comes from the Global VirtualEnv file, which is among a long list of Global files which are being included so that all repos support all editors/OS/etc. https://gitlab.com/coala/mobans/merge_requests/27/diffs#5042e0fe174c9e90b403cf80175c9c8b18257fb1_0_3
Then if someone wants to add any more personally important gitignores, we can tell them to go upstream and then we will import them to all repos consistently.
| # http://iamzed.com/2009/05/07/a-primer-on-virtualenv/ | ||
| .Python | ||
| [Bb]in | ||
| [Ii]nclude |
There was a problem hiding this comment.
include This seems normal in a js project.
There was a problem hiding this comment.
Is it a problem for this repo?
https://gitlab.com/coala/mobans/issues/34 is unrelated to this.
If there is a problematic rule, we override with a !rule
There was a problem hiding this comment.
If I add an include directory and it will be missing in git status.
There was a problem hiding this comment.
Shouldn't git ignore should only ignore files that relevant to its project?
There was a problem hiding this comment.
+targets:
+ - .gitignore: coala-gitignore.jj2
I thought it was because it is using coala-gitignore.jj2 which causing it include python specific project ignore to this project's .gitignore
There was a problem hiding this comment.
This repo is configured to use the node ignore list. Nothing to do with python.
'coala' in coala-ignore filename refers to coala org, not coala tool. These are all global rules for editors, and are all from github.com repos.
There was a problem hiding this comment.
See coala/gh-board#50 which is about a real problem, and how to detect real problems.
|
@blazeu |
| # Virtualenv | ||
| # http://iamzed.com/2009/05/07/a-primer-on-virtualenv/ | ||
| .Python | ||
| [Bb]in |
There was a problem hiding this comment.
Bin also seems normal to include in the repository.
There was a problem hiding this comment.
But not this repository, or any other coala repository, so we're ok to include it ... :/
jayvdb
force-pushed
the
moban
branch
2 times, most recently
from
633e5f1 to
fa53e08
Compare
Use custom Emberjs.gitignore as it doesnt exist upstream in https://github.com/github/gitignore Related to https://gitlab.com/coala/mobans/issues/31
Related to https://gitlab.com/coala/mobans/issues/31