Ticket Panel (Adminhelps & Mentorhelps)

[GeneriedJenelle]

About the pull request

This is a ticket panel intended to improve the staff side management of tickets. It provides a GUI for all admin and mentor tickets in one place, and allows you to see archived ones. There are quick access buttons for the player who is making the original request, and an easy system for labelling tickets with a subject for a quick summary.

Also expands mentorhelps so they have more function comparable to adminhelps.

Explain why it's good for the game

Allows better management of adminhelps and mentorhelps by providing a visual environment and additional features.

Testing Photographs and Procedure

More to come. Will be updated.

Screenshots & Videos

Changelog

🆑
add: Adds Ticket Panel
/:cl:

[matttheficus]

Having a button in the UI to convert mhelps to ahelps and vice-versa would be useful. Only ahelps currently have this feature with the DEFER button (which I dont see on the UI anywho after checking it out), but I can see a use case for both!

[GeneriedJenelle]

Having a button in the UI to convert mhelps to ahelps and vice-versa would be useful. Only ahelps currently have this feature with the DEFER button (which I dont see on the UI anywho after checking it out), but I can see a use case for both!

Good idea, I've just added this into the panel.

[matttheficus]

Would it be possible to add the player's faction/role into the list of info in the panel? Very very very useful for parsing the context of an mhelp.

Hell, just their role (ComTech, HM, Spitter, Drone, etc) would be super useful.

[GeneriedJenelle]

Would it be possible to add the player's faction/role into the list of info in the panel? Very very very useful for parsing the context of an mhelp.

Hell, just their role (ComTech, HM, Spitter, Drone, etc) would be super useful.

Hi @matttheficus do you know whereas in the code this info often gets referenced terms of players? Would help tons.

[matttheficus]

Would it be possible to add the player's faction/role into the list of info in the panel? Very very very useful for parsing the context of an mhelp.
Hell, just their role (ComTech, HM, Spitter, Drone, etc) would be super useful.

Hi @matttheficus do you know whereas in the code this info often gets referenced terms of players? Would help tons.

Humans seem to be .job under mob_defines.dm
Xenos would .caste_type on a xeno mobtype. This can be found under Xenomorph.dm

[MistChristmas]

@GeneriedJenelle is this feature complete, or were you still working on the above.

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[GeneriedJenelle]

A few updates:

• Fixes an unreported bug relating to admin_ticket_log() where key_name_admin(src) was exporting raw html into the message log if you edit variables while having an admin ticket open, uses the key_name(src) instead for the raw message output, which fixes this.

• Update on ticket details, they are fixed to the top of the screen even if you scroll down. Just thought this would be a good idea for longer tickets so you don't have to scroll all the way to the top to remember important details.

• Fixes: "Similar to this, the side bar for Open/Archived doesn't respect the bottom of the window. And will overflow off screen."/"Also this isn't completely resolved as if there's enough entries in the Ticket side bar, it will just overflow, and not be scrollable."

This has been tested on both mentor and admin helps.

• Fixes: "Xenos' faction come up as Neutral"
  Now fixed, xenos weren't coming up because get_faction() doesn't return xeno factions but GLOB.faction_datums does. Switched to that. Still works with marines too.

• Fixes: "Closing mentor ticket/unclaiming a mentor ticket sends an unsorted unformatted message"

• Fixes: "Deferring a ticket with a custom message isn't verbose that someone customised it"

• I've put in a fix for Mentor helps who have clients that leave, can't be closed in the panel despite saying that they've been automatically closed. but you may need to test this on your live run. It appears to work on my side.

• Preemptively I've added a "show more/less" message cutoff for initial messages, in case you get one of those really Mojo-Jojo tier ahelpers.

• Fixes: "Replying to a ticket doesn't auto-mark it. But Trying to Auto-Reply to ahelps won't auto mark it, and won't work unless it's marked. Trying to Auto-Reply to Mentor tickets will mark it and work though"

Now done.

• Fixes: "Using the in-chat mark button on a closed ticket doesn't warn you the ticket is already closed."

• Fixes: "In Mentor tickets, View Notes and Ban are discoloured out even if the user has mod/admin privileges. Probably just preferable if you didn't populate the button if they don't have the permissions"

[Drulikar]

Maybe I missed stuff, but it looks like usage is just very inconsistent for procs as far as how a person is identified as.

Looks like log_mhelp needs to either be key (or even better ckey) since this isn't ever given to a user, and its just file logged so should be a unique identifier (not a external displayname that could change by a player at any moment). Same for log_message.

But notify is to_chat'ed so should have mentor .username() or IC name for the person (unless they're staff)

[Drulikar]

Logging is preferable to have uuids (because again steam users can change their displayname at any time).

Still unresolved issues with the Notify usage above.

[Drulikar]

Thank you for all of your time fussing with this.

Resolved