Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run spec checks in their own GitHub Actions job #2127

Merged
merged 4 commits into from
Feb 23, 2023
Merged

Run spec checks in their own GitHub Actions job #2127

merged 4 commits into from
Feb 23, 2023

Commits on Feb 23, 2023

  1. Run spec checks in their own GitHub Actions job 

    Currently workflows for PRs fail early and nobody knows if the tests
and linters pass or fail.
    @michael-k
    michael-k committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    2629dac View commit details
    Browse the repository at this point in the history

  2. Stop using the deprecated set-output 

    See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
    @michael-k
    michael-k committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    ebdc263 View commit details
    Browse the repository at this point in the history

  3. Pin the Python version used by the maintenance workflow 

    Afaik ubuntu-latest comes with Python 3.10 at the moment.  Also use
`python -m pip` instead of `pip`, see
https://snarky.ca/why-you-should-use-python-m-pip/.
    @michael-k
    michael-k committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    22175c1 View commit details
    Browse the repository at this point in the history

  4. Give the maintenance workflow a name

    @michael-k
    michael-k committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    4d724e9 View commit details
    Browse the repository at this point in the history