Run spec checks in their own GitHub Actions job #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently workflows for PRs fail early and nobody knows if the tests and linters pass or fail.
Afaik ubuntu-latest comes with Python 3.10 at the moment. Also use `python -m pip` instead of `pip`, see https://snarky.ca/why-you-should-use-python-m-pip/.
|
This looks good to get better test results from PRs. I had been thinking to have the maintenance action to commit the spec version used. Then the test action could used the last committed spec version to run tests instead of using the "latest" spec version that usually cause errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and polish the maintenance workflow a bit.
Imho this is better for reviewers (and PR authors):
Before: