Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make certain arguments optional to allow creation of replicas #136

Merged
merged 14 commits into from
Jun 19, 2022
Merged

Make certain arguments optional to allow creation of replicas #136

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2ba5f15
fixed replica db creation
mihaiplesa Apr 11, 2022
1e0d3d9
Auto Format
cloudpossebot Apr 11, 2022
4d099ab
Update main.tf
mihaiplesa Apr 27, 2022
ecab1a4
edited variable descriptions
mihaiplesa Apr 28, 2022
2446a6d
Auto Format
cloudpossebot Apr 28, 2022
0b7f9ce
Update main.tf
mihaiplesa Jun 3, 2022
d7ead01
Apply suggestions from code review
mihaiplesa Jun 3, 2022
13ce6e1
Auto Format
cloudpossebot Jun 3, 2022
41c7858
more fixes
mihaiplesa Jun 7, 2022
05e333e
Auto Format
cloudpossebot Jun 7, 2022
35291a5
description improvements
mihaiplesa Jun 7, 2022
73b9750
formatting
mihaiplesa Jun 7, 2022
1aa869c
Auto Format
cloudpossebot Jun 7, 2022
e6d3ffc
Merge branch 'cloudposse:master' into mplesa-replicate-db-fixes
mihaiplesa Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Auto Format
  • Loading branch information
@cloudpossebot
cloudpossebot committed Jun 7, 2022
commit 1aa869c79f86a5c1d4635e685d6ad1c78b307856
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ resource "aws_db_option_group" "default" {
}

resource "aws_db_subnet_group" "default" {
count = module.this.enabled && local.subnet_ids_provided && !local.db_subnet_group_name_provided ? 1 : 0
count = module.this.enabled && local.subnet_ids_provided && ! local.db_subnet_group_name_provided ? 1 : 0

name = module.this.id
subnet_ids = var.subnet_ids
Expand Down